fix: prevent dsn format bugs when adding tls mode in mysql (kubeflow#1265)

Signed-off-by: Alessio Pragliola <[email protected]>

Author: Al-Pragliola

internal/datastore/embedmd/mysql/connect.go

@@ -5,8 +5,8 @@ import (
 	"time"
 
 	"github.com/go-sql-driver/mysql"
-	_tls "github.com/kubeflow/model-registry/internal/tls"
 	"github.com/golang/glog"
+	_tls "github.com/kubeflow/model-registry/internal/tls"
 	gorm_mysql "gorm.io/driver/mysql"
 	"gorm.io/gorm"
 	"gorm.io/gorm/logger"
@@ -42,7 +42,14 @@ func (c *MySQLDBConnector) Connect() (*gorm.DB, error) {
 			return nil, err
 		}
 
-		c.DSN += "&tls=custom"
+		cfg, err := mysql.ParseDSN(c.DSN)
+		if err != nil {
+			return nil, fmt.Errorf("failed to parse DSN: %w", err)
+		}
+
+		cfg.TLSConfig = "custom"
+
+		c.DSN = cfg.FormatDSN()
 	}
 
 	for i := range mysqlMaxRetries {