Move robot TC to pytest (kubeflow#1105)

* Translate  robot TC to pytest

Signed-off-by: lugi0 <[email protected]>

* Update test to only use methods exposed directly by the client

Signed-off-by: lugi0 <[email protected]>

---------

Signed-off-by: lugi0 <[email protected]>

Author: lugi0

clients/python/README.md

@@ -362,6 +362,35 @@ Check out our [recommendations on setting up your docker engine](https://github.
 
 ### Troubleshooting
 
-- On running `make test test-e2e` if you see a similar problem `unknown flag: --load`, install [buildx](https://formulae.brew.sh/formula/docker-buildx)
+- On running `make test test-e2e` if you see a similar problem `unknown flag: --load`, install [buildx](https://formulae.brew.sh/formula/docker-buildx). You will then need to add `cliPluginsExtraDirs` to ~/.docker/config.json, like so:
+```
+"cliPluginsExtraDirs": [
+      "/opt/homebrew/lib/docker/cli-plugins"  # depending on your system config, brew should give you the proper one
+  ]
+```
+Before running make, ensure docker is running (`docker ps -a`). If it's not, assuming you're using `colima` on macos, run
+`colima start`.
+
+- On running `make test-e2e` you might see an error similar to
+```
+102.7 /workspace/bin/golangci-lint run cmd/... internal/... ./pkg/...  --timeout 3m
+124.6 make: *** [Makefile:243: lint] Killed
+------
+Dockerfile:60
+--------------------
+  58 |     
+  59 |     # prepare the build in a separate layer
+  60 | >>> RUN make clean build/prepare
+  61 |     # compile separately to optimize multi-platform builds
+  62 |     RUN CGO_ENABLED=0 GOOS=${TARGETOS:-linux} GOARCH=${TARGETARCH} make build/compile
+--------------------
+ERROR: failed to solve: process "/bin/sh -c make clean build/prepare" did not complete successfully: exit code: 2
+make[1]: *** [image/build] Error 1
+make: *** [deploy-latest-mr] Error 2
+```
+To solve it, you can try launching `colima` with these settings:
+```
+colima start --cpu 6 --memory 16 --profile docker --arch aarch64 --vm-type=vz --vz-rosetta
+```
 
 <!-- github-only -->

clients/python/tests/test_client.py

@@ -997,3 +997,53 @@ async  def test_register_model_with_owner(client):
     assert rm.owner == model_params["owner"]
     assert (_get_rm := client.get_registered_model(name=model_params["name"]))
     assert _get_rm.owner == model_params["owner"]
+
+
+@pytest.mark.e2e
+async def test_register_model_with_s3_data_connection(client: ModelRegistry):
+    """As a MLOps engineer I want to track a Model from an S3 bucket Data Connection"""
+    data_connection_name = "aws-connection-my-data-connection"
+    s3_bucket = "my-bucket"
+    s3_path = "my-path"
+    s3_endpoint = "https://minio-api.acme.org"
+    s3_region = "us-east-1"
+
+    # Create the S3 URI using the utility function
+    uri = utils.s3_uri_from(
+        path=s3_path,
+        bucket=s3_bucket,
+        endpoint=s3_endpoint,
+        region=s3_region
+    )
+
+    model_params = {
+        "name": "test_model",
+        "uri": uri,
+        "model_format_name": "onnx",
+        "model_format_version": "1",
+        "version": "v1.0",
+        "description": "The Model",  # This will be set on the model version
+        "storage_key": data_connection_name,
+        "storage_path": s3_path
+    }
+
+    # Register the model with S3 connection details
+    rm = client.register_model(**model_params)
+    assert rm.id
+
+    # Get and verify the registered model
+    rm_by_name = client.get_registered_model(model_params["name"])
+    assert rm_by_name.id == rm.id
+
+    # Get and verify the model version
+    mv = client.get_model_version(model_params["name"], model_params["version"])
+    assert mv.description == "The Model"
+    assert mv.name == "v1.0"
+
+    # Get and verify the model artifact
+    ma = client.get_model_artifact(model_params["name"], model_params["version"])
+    assert ma.uri == uri
+    assert ma.model_format_name == "onnx"
+    assert ma.model_format_version == "1"
+    assert ma.storage_key == data_connection_name
+    assert ma.storage_path == s3_path

test/robot/UserStory.robot

@@ -100,6 +100,7 @@ As a MLOps engineer I would like to store an owner for the RegisteredModel
           And Should be equal    ${r["owner"]}    My owner
 
 As a MLOps engineer I want to track a Model from an S3 bucket Data Connection
+    # MIGRATED TO test_register_model_with_s3_data_connection in pytest
     ${data_connection_name}  Set Variable   aws-connection-my-data-connection
     ${s3_bucket}  Set Variable  my-bucket
     ${s3_path}  Set Variable  my-path