Skip to content

Implemented hamburger menu #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Implemented hamburger menu #1

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
33dc5a5
Implemented hamburger menu
Savvy Jun 10, 2019
99c3a05
Migrated from querySelector to refs
Savvy Jun 20, 2019
3c4d7f5
Made consistency changes
Savvy Jun 20, 2019
dfe8e4e
Merge remote-tracking branch 'upstream/master' into hamburger-menu
SebastiaanYN Jun 21, 2019
ef59c7f
Resolve linting errors
SebastiaanYN Jun 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
140 changes: 126 additions & 14 deletions components/Navbar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,31 @@
<template lang="html">
<nav>
<ul>
<li
v-for="item in items"
:key="item.name"
>
<div class="navigation">
Copy link
Member

@SebastiaanYN SebastiaanYN Jun 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a reason for wrapping the nav element in another div

<nav>
<div class="nav-mobile">
<a
:href="item.url"
target="_blank"
rel="noreferrer"
id="nav-toggle"
href="#"
@click="toggleNav"
>
<InlineSvg :src="`icons/${item.name.toLowerCase()}.svg`" /> {{ item.name }}
<span />
</a>
</li>
</ul>
</nav>
</div>
<ul class="nav-list">
<li
v-for="item in items"
:key="item.name"
>
<a
:href="item.url"
target="_blank"
rel="noreferrer"
>
<InlineSvg :src="`icons/${item.name.toLowerCase()}.svg`" /> {{ item.name }}
</a>
</li>
</ul>
</nav>
</div>
</template>

<script>
Expand Down Expand Up @@ -42,6 +53,13 @@ export default {
],
};
},
methods: {
toggleNav(event) {
event.preventDefault();
event.currentTarget.classList.toggle('active');
this.$el.querySelector('.nav-list').classList.toggle('hide');
},
},
};
</script>

Expand All @@ -59,6 +77,97 @@ $desktop: (
padding: 20px,
);

nav {
float: right;
}

.hide {
display: inline-block !important;
height: 100%;
}

.navigation {
background: $black;
height: map-get($mobile, height);
}

.nav-mobile {
display: none;
position: absolute;
top: 0;
right: 0;
background: $black;
height: map-get($mobile, height);
width: map-get($mobile, height);
}

@media only screen and (max-width: 798px) {
// Hamburger nav visible on mobile only
nav {
width: 100%;
padding: map-get($mobile, height) 0 15px;
}

.nav-mobile {
display: block;
}
.nav-list {
width: 100%;
display: none;
}

.nav-list li {
width: 100%;
float: none;
}
}

@media screen and (min-width: 799px) {
.nav-list {
display: block !important;
}
}

#nav-toggle {
position: absolute;
left: 18px;
top: 22px;
cursor: pointer;
padding: 10px 35px 16px 0px;
span,
span:before,
span:after {
cursor: pointer;
border-radius: 1px;
height: 5px;
width: 35px;
background: $yellow;
position: absolute;
display: block;
content: " ";
transition: all 300ms ease-in-out;
}
span:before {
top: -10px;
}
span:after {
bottom: -10px;
}
&.active span {
background-color: transparent;
&:before,
&:after {
top: 0;
}
&:before {
transform: rotate(45deg);
}
&:after {
transform: rotate(-45deg);
}
}
}

ul {
list-style-type: none;
margin: 0;
Expand All @@ -77,9 +186,12 @@ ul {
height: map-get($desktop, height);
}

li {
float: left;
}

li a {
padding: 0 25px;

display: flex;
flex-direction: row;
justify-content: center;
Expand Down