Skip to content

Commit 3baa64f

Browse files
authored
fix: self managed stackset dependencies (#98)
adds an explicit dependency between MgmtAccEBRuleStackSet and associated self managed roles Even though there is an implicit dependency because of the use of Fn::GetAtt, we also need an explicit dependency to handle stack teardown gracefully. Adds cfn-lint exclusion
1 parent 099e26e commit 3baa64f

File tree

2 files changed

+16
-2
lines changed

2 files changed

+16
-2
lines changed

templates_cspm_eventbridge/OrgFullInstall.yaml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,14 @@ Resources:
268268
RoleArn: !Sub "arn:aws:iam::${AWS::AccountId}:role/${EventBridgeRoleName}"
269269
MgmtAccEBRuleStackSet:
270270
Type: AWS::CloudFormation::StackSet
271-
DependsOn: ExecutionRole
271+
Metadata:
272+
cfn-lint:
273+
config:
274+
ignore_checks:
275+
- W3005
276+
DependsOn:
277+
- ExecutionRole
278+
- AdministrationRole
272279
Properties:
273280
StackSetName: MgmtAccEBRuleStackSet
274281
AdministrationRoleARN: !GetAtt AdministrationRole.Arn

templates_eventbridge/OrgEventBridge.yaml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,14 @@ Resources:
132132
Resource: !Sub ${EventBusARN}
133133
MgmtAccEBRuleStackSet:
134134
Type: AWS::CloudFormation::StackSet
135-
DependsOn: ExecutionRole
135+
Metadata:
136+
cfn-lint:
137+
config:
138+
ignore_checks:
139+
- W3005
140+
DependsOn:
141+
- ExecutionRole
142+
- AdministrationRole
136143
Properties:
137144
StackSetName: MgmtAccEBRuleStackSet
138145
AdministrationRoleARN: !GetAtt AdministrationRole.Arn

0 commit comments

Comments
 (0)