docs: clarify ecs/vpc/subnet usage (#60)

* docs: clarify ecs/vpc/subnet usage

* docs: clarify ecs/vpc/subnet usage

* docs: clarify ecs/vpc/subnet usage

Author: iru

templates/CloudVision.yaml

@@ -69,15 +69,25 @@ Parameters:
   ExistentECSCluster:
     Type: String
     Default: ""
-    Description: Leave it blank to let us to deploy the infrastructure required for running Sysdig for Cloud
+    Description: |
+      If left blank new required infrastructure will be deployed; ECS, VPC and Subnet.
+      Otherwise, specify all three parameters.
+    
   ExistentECSClusterVPC:
     Type: String
     Default: ""
-    Description: Leave it blank to let us to deploy the infrastructure required for running Sysdig for Cloud
+    Description: | 
+      If left blank new required infrastructure will be deployed; ECS, VPC and Subnet.
+      Otherwise, specify all three parameters.
+    
   ExistentECSClusterPrivateSubnets:
     Type: List<String>
     Default: ""
-    Description: Leave it blank to let us to deploy the infrastructure required for running Sysdig for Cloud
+    Description: | 
+      If left blank new required infrastructure will be deployed; ECS, VPC and Subnet.
+      Otherwise, specify all three parameters.
+      Two subnets are required. eg. 'subnet-foo, subnet-bar'
+    
   ExistentCloudTrailSNSTopic:
     Type: String
     Default: ""
@@ -206,4 +216,4 @@ Resources:
       Parameters:
         SysdigRoleName: !Ref SysdigRoleName
         SysdigExternalID: !Ref SysdigExternalID
-        SysdigTrustedIdentity: !Ref SysdigTrustedIdentity
+        SysdigTrustedIdentity: !Ref SysdigTrustedIdentity

templates/Makefile

@@ -1,7 +1,9 @@
+# requires AWS_PROFILE
+# bucket will be created if it does not exist
 S3_BUCKET ?= "s4c-cft"
 S3_PREFIX ?= "test"
 # We need the REGION or the TemplateURLs might be created for a different region, resulting in a deployment error
-S3_REGION ?= "eu-west-1"
+S3_REGION ?= "eu-west-1" # ireland
 SECURE_API_TOKEN ?= ""
 
 .PHONY: packaged-template.yaml
@@ -37,3 +39,11 @@ ci: packaged-template.yaml
 
 clean:
 	aws cloudformation delete-stack --stack-name "CloudVisionTest"
+	
+	
+#	
+# local-test-manual:
+# (have not found a way to do it via cli)
+# aws console > cloudformation > create new stack (template, upload template: select ./templates/Cloudvision.yaml)
+# note: this will upload the template into an s3 bucket, remember to delete it afterwards 
+#