Skip to content

Commit d47fe8d

Browse files
authored
Revert to ExternalID naming convention (#104)
1 parent 1a3144a commit d47fe8d

File tree

3 files changed

+19
-19
lines changed

3 files changed

+19
-19
lines changed

templates_cloudlogs/CloudLogs.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,14 @@ Metadata:
1111
default: "Sysdig Settings (Do not change)"
1212
Parameters:
1313
- CloudLogsRoleName
14-
- ExternalId
14+
- ExternalID
1515
- TrustedIdentity
1616
- BucketARN
1717

1818
ParameterLabels:
1919
CloudLogsRoleName:
2020
default: "Role Name (Sysdig use only)"
21-
ExternalId:
21+
ExternalID:
2222
default: "External ID (Sysdig use only)"
2323
TrustedIdentity:
2424
default: "Trusted Identity (Sysdig use only)"
@@ -29,7 +29,7 @@ Parameters:
2929
CloudLogsRoleName:
3030
Type: String
3131
Description: The name of the IAM Role that will enable access to the Cloudtrail logs.
32-
ExternalId:
32+
ExternalID:
3333
Type: String
3434
Description: Random string generated unique to a customer.
3535
TrustedIdentity:
@@ -54,7 +54,7 @@ Resources:
5454
- "sts:AssumeRole"
5555
Condition:
5656
StringEquals:
57-
"sts:ExternalId": !Ref ExternalId
57+
"sts:ExternalId": !Ref ExternalID
5858
CloudLogsRolePolicies:
5959
Type: "AWS::IAM::Policy"
6060
Properties:

templates_cspm_cloudlogs/FullInstall.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ Metadata:
99
Parameters:
1010
- CSPMRoleName
1111
- CloudLogsRoleName
12-
- ExternalId
12+
- ExternalID
1313
- TrustedIdentity
1414
- BucketARN
1515

@@ -18,7 +18,7 @@ Metadata:
1818
default: "CSPM Role Name (Sysdig use only)"
1919
CloudLogsRoleName:
2020
default: "CloudLogs Role Name (Sysdig use only)"
21-
ExternalId:
21+
ExternalID:
2222
default: "External ID (Sysdig use only)"
2323
TrustedIdentity:
2424
default: "Trusted Identity (Sysdig use only)"
@@ -32,7 +32,7 @@ Parameters:
3232
CloudLogsRoleName:
3333
Type: String
3434
Description: The name of the IAM Role that will enable access to the Cloudtrail logs.
35-
ExternalId:
35+
ExternalID:
3636
Type: String
3737
Description: Sysdig ExternalID required for the policy creation
3838
TrustedIdentity:
@@ -57,7 +57,7 @@ Resources:
5757
Action: "sts:AssumeRole"
5858
Condition:
5959
StringEquals:
60-
sts:ExternalId: !Ref ExternalId
60+
sts:ExternalId: !Ref ExternalID
6161
ManagedPolicyArns:
6262
- arn:aws:iam::aws:policy/SecurityAudit
6363
CloudLogsRole:
@@ -74,7 +74,7 @@ Resources:
7474
- "sts:AssumeRole"
7575
Condition:
7676
StringEquals:
77-
"sts:ExternalId": !Ref ExternalId
77+
"sts:ExternalId": !Ref ExternalID
7878
CloudLogsRolePolicies:
7979
Type: "AWS::IAM::Policy"
8080
Properties:

templates_cspm_cloudlogs/OrgFullInstall.yaml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ Metadata:
99
Parameters:
1010
- CSPMRoleName
1111
- CloudLogsRoleName
12-
- ExternalId
12+
- ExternalID
1313
- TrustedIdentity
1414
- BucketARN
1515
- OrganizationUnitIDs
@@ -19,7 +19,7 @@ Metadata:
1919
default: "CSPM Role Name (Sysdig use only)"
2020
CloudLogsRoleName:
2121
default: "CloudLogs Role Name (Sysdig use only)"
22-
ExternalId:
22+
ExternalID:
2323
default: "External ID (Sysdig use only)"
2424
BucketARN:
2525
default: "Bucket ARN"
@@ -35,7 +35,7 @@ Parameters:
3535
CloudLogsRoleName:
3636
Type: String
3737
Description: The name of the IAM Role that will enable access to the Cloudtrail logs.
38-
ExternalId:
38+
ExternalID:
3939
Type: String
4040
Description: Sysdig ExternalID required for the policy creation
4141
BucketARN:
@@ -62,7 +62,7 @@ Resources:
6262
Action: "sts:AssumeRole"
6363
Condition:
6464
StringEquals:
65-
sts:ExternalId: !Sub ${ExternalId}
65+
sts:ExternalId: !Sub ${ExternalID}
6666
ManagedPolicyArns:
6767
- arn:aws:iam::aws:policy/SecurityAudit
6868
CloudLogsRole:
@@ -79,7 +79,7 @@ Resources:
7979
- "sts:AssumeRole"
8080
Condition:
8181
StringEquals:
82-
"sts:ExternalId": !Ref ExternalId
82+
"sts:ExternalId": !Ref ExternalID
8383
CloudLogsRolePolicies:
8484
Type: "AWS::IAM::Policy"
8585
Properties:
@@ -116,8 +116,8 @@ Resources:
116116
ParameterValue: !Ref CloudLogsRoleName
117117
- ParameterKey: TrustedIdentity
118118
ParameterValue: !Ref TrustedIdentity
119-
- ParameterKey: ExternalId
120-
ParameterValue: !Ref ExternalId
119+
- ParameterKey: ExternalID
120+
ParameterValue: !Ref ExternalID
121121
- ParameterKey: BucketARN
122122
ParameterValue: !Ref BucketARN
123123
StackInstancesGroup:
@@ -140,7 +140,7 @@ Resources:
140140
BucketARN:
141141
Type: String
142142
Description: The ARN of your s3 bucket associated with your Cloudtrail trail.
143-
ExternalId:
143+
ExternalID:
144144
Type: String
145145
Description: Sysdig ExternalID required for the policy creation
146146
Resources:
@@ -157,7 +157,7 @@ Resources:
157157
Action: "sts:AssumeRole"
158158
Condition:
159159
StringEquals:
160-
sts:ExternalId: !Sub ${ExternalId}
160+
sts:ExternalId: !Sub ${ExternalID}
161161
ManagedPolicyArns:
162162
- arn:aws:iam::aws:policy/SecurityAudit
163163
CloudLogsRole:
@@ -174,7 +174,7 @@ Resources:
174174
- "sts:AssumeRole"
175175
Condition:
176176
StringEquals:
177-
"sts:ExternalId": !Ref ExternalId
177+
"sts:ExternalId": !Ref ExternalID
178178
CloudLogsRolePolicies:
179179
Type: "AWS::IAM::Policy"
180180
Properties:

0 commit comments

Comments
 (0)