From a922a20843baf5bdf0bfd60ae91a9a4fdb5ce563 Mon Sep 17 00:00:00 2001 From: Miguel Pais Date: Sat, 14 Dec 2024 10:45:01 +0100 Subject: [PATCH 1/4] Trying to see if linting goes away --- modules/foundational.cft.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/modules/foundational.cft.yaml b/modules/foundational.cft.yaml index 2efc86b..1da070b 100644 --- a/modules/foundational.cft.yaml +++ b/modules/foundational.cft.yaml @@ -171,6 +171,11 @@ Resources: - Ref: AWS::Region TemplateBody: | AWSTemplateFormatVersion: "2010-09-09" + Metadata: + cfn-lint: + config: + ignore_checks: + - E0003 Description: IAM Role for Agentless Parameters: NameSuffix: From 942feec68d749dca5b38d82e4b47e01a754e937a Mon Sep 17 00:00:00 2001 From: Miguel Pais Date: Sat, 14 Dec 2024 10:53:27 +0100 Subject: [PATCH 2/4] trying again --- .github/workflows/ci-modules.yaml | 4 +++- modules/foundational.cft.yaml | 5 ----- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci-modules.yaml b/.github/workflows/ci-modules.yaml index e0b5a82..8529252 100644 --- a/.github/workflows/ci-modules.yaml +++ b/.github/workflows/ci-modules.yaml @@ -25,11 +25,13 @@ jobs: - name: cfn-lint uses: scottbrenner/cfn-lint-action@v2 + with: + version: 1.18.3 - name: Lint working-directory: modules run: make lint - + validate: name: Validate Templates runs-on: ubuntu-latest diff --git a/modules/foundational.cft.yaml b/modules/foundational.cft.yaml index 1da070b..2efc86b 100644 --- a/modules/foundational.cft.yaml +++ b/modules/foundational.cft.yaml @@ -171,11 +171,6 @@ Resources: - Ref: AWS::Region TemplateBody: | AWSTemplateFormatVersion: "2010-09-09" - Metadata: - cfn-lint: - config: - ignore_checks: - - E0003 Description: IAM Role for Agentless Parameters: NameSuffix: From 7a14ecb86516b96bfd2045405fc52d46d4cec117 Mon Sep 17 00:00:00 2001 From: Miguel Pais Date: Sat, 14 Dec 2024 10:59:13 +0100 Subject: [PATCH 3/4] dummy change to force linting --- modules/foundational.cft.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/foundational.cft.yaml b/modules/foundational.cft.yaml index 2efc86b..964b15d 100644 --- a/modules/foundational.cft.yaml +++ b/modules/foundational.cft.yaml @@ -259,7 +259,7 @@ Resources: Outputs: ConfigPostureRoleARN: - Description: ARN of the config posture role + Description: ARN of the config for posture role Value: Fn::Sub: ${ConfigPostureRole.Arn} OnboardingRoleARN: From c5de8133e965ef8f464986a00ab70d2ebbb73f46 Mon Sep 17 00:00:00 2001 From: Miguel Pais Date: Sun, 15 Dec 2024 08:56:19 +0100 Subject: [PATCH 4/4] comment from ravhina --- modules/foundational.cft.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/foundational.cft.yaml b/modules/foundational.cft.yaml index 964b15d..1f21d4c 100644 --- a/modules/foundational.cft.yaml +++ b/modules/foundational.cft.yaml @@ -259,7 +259,7 @@ Resources: Outputs: ConfigPostureRoleARN: - Description: ARN of the config for posture role + Description: ARN of the role for config posture Value: Fn::Sub: ${ConfigPostureRole.Arn} OnboardingRoleARN: