Skip to content

Commit 022c547

Browse files
authored
feat(registry-scanner): Add flag to enable mem profile dumps on a PVC (#1455)
1 parent d20be64 commit 022c547

File tree

4 files changed

+20
-3
lines changed

4 files changed

+20
-3
lines changed

charts/registry-scanner/Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ description: Sysdig Registry Scanner
44
type: application
55
home: https://sysdiglabs.github.io/registry-scanner/
66
icon: https://478h5m1yrfsa3bbe262u7muv-wpengine.netdna-ssl.com/wp-content/uploads/2019/02/Shovel_600px.png
7-
version: 1.1.16
8-
appVersion: 0.2.54
7+
version: 1.1.17
8+
appVersion: 0.2.56
99
maintainers:
1010
- name: giuse-sysdig
1111

charts/registry-scanner/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ The following table lists the configurable parameters of the Sysdig Registry Sca
115115
| scanOnStart.jobName | The name of the job created for the post-install scanner job | <code>"registry-scanner-start-test"</code> |
116116
| scanOnStart.asPostInstallHook | Specify whether to launch the job as a post-install helm hook. <br/>Used for testing purpose. | <code>false</code> |
117117
| extraEnvVars | The additional environment variables to be set. | <code>[]</code> |
118+
| memProfileToPersistentVolumeClaim | Write memory profile dumps to Persistent Volume Claim (provide PVC name) | <code>""</code> |
118119

119120
## On-Prem Deployment
120121

@@ -126,7 +127,7 @@ Use the following command to deploy:
126127
helm upgrade --install registry-scanner \
127128
--namespace sysdig-agent \
128129
--create-namespace \
129-
--version=1.1.16 \
130+
--version=1.1.17 \
130131
--set config.secureBaseURL=<SYSDIG_SECURE_URL> \
131132
--set config.secureAPIToken=<SYSDIG_SECURE_API_TOKEN> \
132133
--set config.secureSkipTLS=true \

charts/registry-scanner/templates/_job.tpl

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,10 @@
3838
- name: report-storage
3939
mountPath: "/output"
4040
{{- end }}
41+
{{- if .Values.memProfileToPersistentVolumeClaim }}
42+
- name: profile-storage
43+
mountPath: "/profiling"
44+
{{- end }}
4145
{{- if .Values.ssl.ca.certs }}
4246
- name: ca-certs
4347
mountPath: "/ca-certs"
@@ -120,6 +124,10 @@
120124
- name: GROUP_LIMIT
121125
value: "{{ .Values.config.parallelGoRoutines }}"
122126
{{- end }}
127+
{{- if .Values.memProfileToPersistentVolumeClaim }}
128+
- name: PROFILING_ENABLED
129+
value: /profiling
130+
{{- end }}
123131
{{- if .Values.extraEnvVars }}
124132
{{- toYaml .Values.extraEnvVars | nindent 10 }}
125133
{{- end }}
@@ -154,4 +162,9 @@
154162
persistentVolumeClaim:
155163
claimName: {{ .Values.reportToPersistentVolumeClaim }}
156164
{{- end }}
165+
{{- if .Values.memProfileToPersistentVolumeClaim }}
166+
- name: profile-storage
167+
persistentVolumeClaim:
168+
claimName: {{ .Values.memProfileToPersistentVolumeClaim }}
169+
{{- end }}
157170
{{- end }}

charts/registry-scanner/values.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -224,3 +224,6 @@ scanOnStart:
224224
extraEnvVars: []
225225
# - name: FOO
226226
# value: bar
227+
228+
# Write memory profile dumps to Persistent Volume Claim (provide PVC name)
229+
memProfileToPersistentVolumeClaim: ""

0 commit comments

Comments
 (0)