feat(agent): convert alf config to secret (#2294)

Author: aroberts87

charts/agent/Chart.yaml

@@ -30,4 +30,4 @@ sources:
 - https://app.sysdigcloud.com/#/settings/user
 - https://github.com/draios/sysdig
 type: application
-version: 2.0.0
+version: 2.1.0

charts/agent/templates/_helpers.tpl

@@ -618,9 +618,9 @@ true
     {{- end -}}
 {{- end -}}
 
-{{/* Return the name of the local forwarder configmap */}}
-{{- define "agent.localForwarderConfigMapName" }}
-{{- include "agent.configmapName" . | trunc 46 | trimSuffix "-" | printf "%s-local-forwarder" }}
+{{/* Return the name of the local forwarder secret */}}
+{{- define "agent.localForwarderSecretName" }}
+{{- include "agent.fullname" . | trunc 46 | trimSuffix "-" | printf "%s-local-forwarder" }}
 {{- end }}
 
 {{- define "agent.enableHttpProbes" }}

charts/agent/templates/configmap-local-forwarder.yaml

@@ -393,9 +393,8 @@ spec:
             optional: true
         {{- if .Values.localForwarder.enabled }}
         - name: local-forwarder-config
-          configMap:
-            name: {{ include "agent.localForwarderConfigMapName" . }}
-            optional: true
+          secret:
+            secretName: {{ include "agent.localForwarderSecretName" . }}
         {{- end }}
         - name: sysdig-agent-secrets
           secret:

charts/agent/templates/daemonset.yaml

@@ -49,3 +49,16 @@ type: Opaque
 data:
 {{ include "agent.httpProxyCredentials" . | indent 2 }}
 {{- end }}
+{{- if .Values.localForwarder.enabled }}
+---
+apiVersion: v1
+kind: Secret
+type: Opaque
+metadata:
+  name: {{ include "agent.localForwarderSecretName" . }}
+  namespace: {{ include "agent.namespace" . }}
+  labels:
+{{ (include "agent.labels" .) | indent 4 }}
+data:
+  local_forwarder_config.yaml: {{ pick .Values.localForwarder "integrations" | toYaml | b64enc | quote }}
+{{- end }}

charts/agent/templates/secrets.yaml

@@ -1,7 +1,7 @@
 suite: Test enabling the agent local forwarder
 templates:
   - configmap.yaml
-  - configmap-local-forwarder.yaml
+  - secrets.yaml
   - daemonset.yaml
 kubernetesProvider:
   scheme:
@@ -18,6 +18,11 @@ kubernetesProvider:
     status:
       nodeInfo:
         osImage: fake-os-image
+release:
+  name: sysdig
+set:
+  sysdig:
+    accessKey: AAAAAAAA-BBBB-CCCC-DDDD-EEEEEEEEEEEE
 tests:
   - it: Check the enabling the forwarder
     set:
@@ -32,16 +37,11 @@ tests:
             type: LOCAL
     asserts:
       - equal:
-          path: data["local_forwarder_config.yaml"]
-          value: |
-            integrations:
-              - channels:
-                - SECURE_EVENTS_POLICIES
-                - ACTIVITY_AUDIT
-                configuration:
-                  output: stdout
-                type: LOCAL
-        template: configmap-local-forwarder.yaml
+          path: data
+          value:
+            local_forwarder_config.yaml: aW50ZWdyYXRpb25zOgotIGNoYW5uZWxzOgogIC0gU0VDVVJFX0VWRU5UU19QT0xJQ0lFUwogIC0gQUNUSVZJVFlfQVVESVQKICBjb25maWd1cmF0aW9uOgogICAgb3V0cHV0OiBzdGRvdXQKICB0eXBlOiBMT0NBTA==
+        documentIndex: 1
+        template: secrets.yaml
       - matchRegex:
           path: data["dragent.yaml"]
           pattern: |
@@ -55,9 +55,8 @@ tests:
           path: spec.template.spec.volumes
           content:
             name: local-forwarder-config
-            configMap:
-              name: sysdig-agent-local-forwarder
-              optional: true
+            secret:
+              secretName: sysdig-agent-local-forwarder
         template: daemonset.yaml
       - contains:
           path: spec.template.spec.containers[0].volumeMounts

charts/agent/tests/local_forwarder_test.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 name: sysdig-deploy
 description: A chart with various Sysdig components for Kubernetes
 type: application
-version: 1.86.1
+version: 1.87.0
 maintainers:
   - name: AlbertoBarba
     email: [email protected]
@@ -26,7 +26,7 @@ dependencies:
   - name: agent
     # repository: https://charts.sysdig.com
     repository: file://../agent
-    version: ~2.0.0
+    version: ~2.1.0
     alias: agent
     condition: agent.enabled
   - name: common