chore: split cert_manager validation and cert_manager enabled utilities

Author: francesco-furlan

charts/shield/templates/cluster/_tls.tpl

@@ -59,14 +59,19 @@
   {{- end -}}
 {{- end }}
 
-{{- define "cluster.tls_certificates.use_cert_manager" -}}
+{{- define "cluster.tls_certificates.validate_cert_manager" -}}
   {{- if and .Values.cluster.tls_certificates.cert_manager .Values.cluster.tls_certificates.cert_manager.enabled -}}
     {{- if and (not .Values.cluster.tls_certificates.cert_manager.ca.generate) (not .Values.cluster.tls_certificates.cert_manager.ca.secret_name) -}}
       {{- fail "cert_manager.ca.secret_name must be specified when CA generation is disabled" -}}
     {{- end -}}
     {{- if and (not .Values.cluster.tls_certificates.cert_manager.issuer.generate) (not .Values.cluster.tls_certificates.cert_manager.issuer.name) -}}
       {{- fail "cert_manager.issuer.name must be specified when Issuer generation is disabled" -}}
     {{- end -}}
+  {{- end -}}
+{{- end }}
+
+{{- define "cluster.tls_certificates.use_cert_manager" -}}
+  {{- if and .Values.cluster.tls_certificates.cert_manager .Values.cluster.tls_certificates.cert_manager.enabled -}}
     {{- true -}}
   {{- end -}}
 {{- end }}

charts/shield/templates/cluster/cert-manager-certificate.yaml

@@ -1,4 +1,5 @@
 {{- if (include "cluster.tls_certificates.use_cert_manager" .) }}
+{{- include "cluster.tls_certificates.validate_cert_manager" . -}}
 ---
 apiVersion: cert-manager.io/v1
 kind: Certificate