fix: Linter and Tests errors

Author: alecron

tests/events_feed_test.py

@@ -4,8 +4,9 @@
 
 from http import HTTPStatus
 from tools.events_feed.tool import EventsFeedTools
+from utils.app_config import AppConfig
 from .conftest import util_load_json
-from unittest.mock import MagicMock, AsyncMock
+from unittest.mock import MagicMock, AsyncMock, create_autospec
 import os
 
 # Get the absolute path of the current module file
@@ -17,19 +18,28 @@
 EVENT_INFO_RESPONSE = util_load_json(f"{module_directory}/test_data/events_feed/event_info_response.json")
 
 
+def mock_app_config() -> AppConfig:
+    mock_cfg = create_autospec(AppConfig, instance=True)
+
+    mock_cfg.sysdig_endpoint.return_value = "https://us2.app.sysdig.com"
+    mock_cfg.transport.return_value = "stdio"
+    mock_cfg.log_level.return_value = "DEBUG"
+    mock_cfg.port.return_value = 8080
+
+    return mock_cfg
+
 def test_get_event_info(mock_success_response: MagicMock | AsyncMock, mock_creds) -> None:
     """Test the get_event_info tool method.
     Args:
         mock_success_response (MagicMock | AsyncMock): Mocked response object.
         mock_creds: Mocked credentials.
     """
-    # Override the environment variable for MCP transport
-    os.environ["MCP_TRANSPORT"] = "stdio"
     # Successful response
     mock_success_response.return_value.json.return_value = EVENT_INFO_RESPONSE
     mock_success_response.return_value.status_code = HTTPStatus.OK
 
-    tools_client = EventsFeedTools()
+    tools_client = EventsFeedTools(app_config=mock_app_config())
+
     # Pass the mocked Context object
     result: dict = tools_client.tool_get_event_info("12345")
     results: dict = result["results"]

tools/events_feed/tool.py

@@ -189,6 +189,9 @@ def tool_get_event_process_tree(self, event_id: str) -> dict:
 
         Returns:
             dict: A dictionary containing the process tree information for the specified event.
+
+        Raises:
+            ToolError: If there is an error constructing or processing the response.
         """
         try:
             start_time = time.time()

tools/vulnerability_management/tool.py

@@ -304,7 +304,9 @@ def tool_get_vulnerability_policy(
             response: GetPolicyResponse = vulnerability_api.secure_vulnerability_v1_policies_policy_id_get(policy_id)
             return response.model_dump_json() if hasattr(response, "dict") else response
         except ToolError as e:
-            self.log.error(f"Exception when calling VulnerabilityManagementApi->secure_vulnerability_v1_policies_policy_id_get: {e}")
+            self.log.error(
+                f"Exception when calling VulnerabilityManagementApi->secure_vulnerability_v1_policies_policy_id_get: {e}"
+            )
             raise e
 
     def tool_list_vulnerability_policies(
@@ -343,7 +345,9 @@ def tool_list_vulnerability_policies(
             )
             return response
         except ToolError as e:
-            self.log.error(f"Exception when calling VulnerabilityManagementApi->secure_vulnerability_v1_policies_get: {e}")
+            self.log.error(
+                f"Exception when calling VulnerabilityManagementApi->secure_vulnerability_v1_policies_get: {e}"
+            )
             raise e
 
     def tool_list_pipeline_scan_results(
@@ -409,7 +413,9 @@ def tool_list_pipeline_scan_results(
             )
             return response
         except ToolError as e:
-            self.log.error(f"Exception when calling VulnerabilityManagementApi->secure_vulnerability_v1_policies_get: {e}")
+            self.log.error(
+                f"Exception when calling VulnerabilityManagementApi->secure_vulnerability_v1_policies_get: {e}"
+            )
             raise e
 
     def tool_get_scan_result(self, scan_id: str) -> dict:
@@ -427,7 +433,9 @@ def tool_get_scan_result(self, scan_id: str) -> dict:
             resp: ScanResultResponse = vulnerability_api.secure_vulnerability_v1_results_result_id_get(scan_id)
             return resp.model_dump_json() if hasattr(resp, "dict") else resp
         except ToolError as e:
-            self.log.error(f"Exception when calling VulnerabilityManagementApi->secure_vulnerability_v1_results_result_id_get: {e}")
+            self.log.error(
+                f"Exception when calling VulnerabilityManagementApi->secure_vulnerability_v1_results_result_id_get: {e}"
+            )
             raise e
 
     def explore_vulnerabilities_prompt(self, filters: str) -> PromptMessage:

utils/app_config.py

@@ -28,27 +28,38 @@ def __init__(self, config: dict):
     def sysdig_endpoint(self) -> str:
         """
         Get the Sysdig endpoint from the app config
+
+        Returns:
+            str: The Sysdig API host (e.g., "https://us2.app.sysdig.com").
         """
-        return self.app_config["sysdig"]["host"]
+        return os.environ.get("SYSDIG_HOST", self.app_config["sysdig"]["host"])
 
     def transport(self) -> str:
         """
         Get the transport protocol (lower case) from the app config
+
+        Returns:
+            str: The transport protocol (e.g., "stdio", "streamable-http", or "sse").
         """
         return os.environ.get("MCP_TRANSPORT", self.app_config["mcp"]["transport"]).lower()
 
-    @staticmethod
-    def log_level() -> str:
+    def log_level(self) -> str:
         """
-        Get the log level from the app config
+        Get the log level from the environment or defaults.
+
+        Returns:
+            str: The log level string (e.g., "DEBUG", "INFO", "WARNING", "ERROR").
         """
         return os.environ.get("LOGLEVEL", "ERROR")
 
     def port(self) -> int:
         """
         Get the port from the app config
+
+        Returns:
+            int: The MCP server port.
         """
-        return self.app_config["mcp"]["port"]
+        return os.environ.get("SYSDIG_MCP_PORT", self.app_config["mcp"]["port"])
 
 
 def env_constructor(loader, node):
@@ -75,7 +86,7 @@ def load_app_config() -> AppConfig:
     Load the app config from the YAML file
 
     Returns:
-        dict: The app config loaded from the YAML file
+        AppConfig: The loaded application configuration wrapper.
     """
     if not check_config_file_exists():
         log.error("Config file does not exist")
@@ -100,7 +111,7 @@ def get_app_config() -> AppConfig:
     If the config is already loaded, it returns the existing config.
 
     Returns:
-        dict: The app config loaded from the YAML file, or an empty dict if the file does not exist or is invalid.
+        AppConfig: The singleton application configuration wrapper.
     """
     global _app_config
     if _app_config is None:

utils/query_helpers.py

@@ -12,7 +12,9 @@
 
 def _parse_response_to_obj(results: RESTResponseType | dict | list | str | bytes) -> dict | list:
     """Best-effort conversion of various response types into a Python object.
-    Returns {} on empty/non-JSON bodies.
+
+    Returns:
+        dict | list: Parsed JSON-compatible object. Returns {} on empty or non-JSON bodies.
     """
     # Already a Python structure
     if results is None:
@@ -69,10 +71,18 @@ def _parse_response_to_obj(results: RESTResponseType | dict | list | str | bytes
     return {}
 
 
-def create_standard_response(results: RESTResponseType, execution_time_ms: float, **metadata_kwargs) -> dict:
+def create_standard_response(results: RESTResponseType, execution_time_ms: float | str, **metadata_kwargs) -> dict:
     """
     Creates a standard response format for API calls. Tolerates empty/non-JSON bodies.
-    Raises ApiException if the HTTP status is >= 300 (when available).
+
+    Returns:
+        dict: A dictionary with keys:
+            - results: parsed body as dict or list (possibly empty {})
+            - metadata: includes execution_time_ms (float) and ISO8601 UTC timestamp
+            - status_code: HTTP status code (int)
+
+    Raises:
+        ApiException: If the HTTP status is >= 300 when status information is available.
     """
     status = getattr(results, "status", 200)
     reason = getattr(results, "reason", "")