feat: add destructive hint annotations to all MCP tools

tembleking · tembleking · commit 53ad225a5eea · 2025-11-25T15:56:15.000+01:00
diff --git a/internal/infra/mcp/tools/tool_generate_sysql.go b/internal/infra/mcp/tools/tool_generate_sysql.go
@@ -54,6 +54,7 @@ func (h *ToolGenerateSysql) RegisterInServer(s *server.MCPServer) {
 		),
 		mcp.WithOutputSchema[map[string]any](),
 		mcp.WithReadOnlyHintAnnotation(true),
+		mcp.WithDestructiveHintAnnotation(false),
 		WithRequiredPermissions("sage.exec"),
 	)
 	s.AddTool(tool, h.handle)
diff --git a/internal/infra/mcp/tools/tool_get_event_info.go b/internal/infra/mcp/tools/tool_get_event_info.go
@@ -44,6 +44,7 @@ func (h *ToolGetEventInfo) RegisterInServer(s *server.MCPServer) {
 		),
 		mcp.WithOutputSchema[map[string]any](),
 		mcp.WithReadOnlyHintAnnotation(true),
+		mcp.WithDestructiveHintAnnotation(false),
 		WithRequiredPermissions("policy-events.read"),
 	)
 
diff --git a/internal/infra/mcp/tools/tool_get_event_process_tree.go b/internal/infra/mcp/tools/tool_get_event_process_tree.go
@@ -62,6 +62,7 @@ func (h *ToolGetEventProcessTree) RegisterInServer(s *server.MCPServer) {
 		),
 		mcp.WithOutputSchema[map[string]any](),
 		mcp.WithReadOnlyHintAnnotation(true),
+		mcp.WithDestructiveHintAnnotation(false),
 		WithRequiredPermissions("policy-events.read"),
 	)
 
diff --git a/internal/infra/mcp/tools/tool_kubernetes_list_clusters.go b/internal/infra/mcp/tools/tool_kubernetes_list_clusters.go
@@ -31,6 +31,7 @@ func (t *KubernetesListClusters) RegisterInServer(s *server.MCPServer) {
 		),
 		mcp.WithOutputSchema[map[string]any](),
 		mcp.WithReadOnlyHintAnnotation(true),
+		mcp.WithDestructiveHintAnnotation(false),
 		WithRequiredPermissions(), // FIXME(fede): Add the required permissions. It should be `promql.exec` but somehow the token does not have that permission even if you are able to execute queries.
 	)
 	s.AddTool(tool, t.handle)
diff --git a/internal/infra/mcp/tools/tool_kubernetes_list_cronjobs.go b/internal/infra/mcp/tools/tool_kubernetes_list_cronjobs.go
@@ -34,6 +34,7 @@ func (t *KubernetesListCronjobs) RegisterInServer(s *server.MCPServer) {
 		),
 		mcp.WithOutputSchema[map[string]any](),
 		mcp.WithReadOnlyHintAnnotation(true),
+		mcp.WithDestructiveHintAnnotation(false),
 		WithRequiredPermissions(), // FIXME(fede): Add the required permissions. It should be `promql.exec` but somehow the token does not have that permission even if you are able to execute queries.
 	)
 	s.AddTool(tool, t.handle)
diff --git a/internal/infra/mcp/tools/tool_kubernetes_list_nodes.go b/internal/infra/mcp/tools/tool_kubernetes_list_nodes.go
@@ -33,6 +33,7 @@ func (t *KubernetesListNodes) RegisterInServer(s *server.MCPServer) {
 		),
 		mcp.WithOutputSchema[map[string]any](),
 		mcp.WithReadOnlyHintAnnotation(true),
+		mcp.WithDestructiveHintAnnotation(false),
 		WithRequiredPermissions(), // FIXME(fede): Add the required permissions. It should be `promql.exec` but somehow the token does not have that permission even if you are able to execute queries.
 	)
 	s.AddTool(tool, t.handle)
diff --git a/internal/infra/mcp/tools/tool_kubernetes_list_pod_containers.go b/internal/infra/mcp/tools/tool_kubernetes_list_pod_containers.go
@@ -39,6 +39,7 @@ func (t *KubernetesListPodContainers) RegisterInServer(s *server.MCPServer) {
 		),
 		mcp.WithOutputSchema[map[string]any](),
 		mcp.WithReadOnlyHintAnnotation(true),
+		mcp.WithDestructiveHintAnnotation(false),
 		WithRequiredPermissions(), // FIXME(fede): Add the required permissions. It should be `promql.exec` but somehow the token does not have that permission even if you are able to execute queries.
 	)
 	s.AddTool(tool, t.handle)
diff --git a/internal/infra/mcp/tools/tool_kubernetes_list_workloads.go b/internal/infra/mcp/tools/tool_kubernetes_list_workloads.go
@@ -43,6 +43,7 @@ func (t *KubernetesListWorkloads) RegisterInServer(s *server.MCPServer) {
 		),
 		mcp.WithOutputSchema[map[string]any](),
 		mcp.WithReadOnlyHintAnnotation(true),
+		mcp.WithDestructiveHintAnnotation(false),
 		WithRequiredPermissions(), // FIXME(fede): Add the required permissions. It should be `promql.exec` but somehow the token does not have that permission even if you are able to execute queries.
 	)
 	s.AddTool(tool, t.handle)
diff --git a/internal/infra/mcp/tools/tool_list_runtime_events.go b/internal/infra/mcp/tools/tool_list_runtime_events.go
@@ -100,6 +100,7 @@ You can specify the severity of the events based on the following cases:
 		),
 		mcp.WithOutputSchema[map[string]any](),
 		mcp.WithReadOnlyHintAnnotation(true),
+		mcp.WithDestructiveHintAnnotation(false),
 		WithRequiredPermissions("policy-events.read"),
 	)
 
diff --git a/internal/infra/mcp/tools/tool_run_sysql.go b/internal/infra/mcp/tools/tool_run_sysql.go
@@ -61,6 +61,7 @@ func (h *ToolRunSysql) RegisterInServer(s *server.MCPServer) {
 		),
 		mcp.WithOutputSchema[map[string]any](),
 		mcp.WithReadOnlyHintAnnotation(true),
+		mcp.WithDestructiveHintAnnotation(false),
 		WithRequiredPermissions("sage.exec", "risks.read"),
 	)
 	s.AddTool(tool, h.handle)
diff --git a/internal/infra/mcp/tools/tool_troubleshoot_kubernetes_list_count_pods_per_cluster.go b/internal/infra/mcp/tools/tool_troubleshoot_kubernetes_list_count_pods_per_cluster.go
@@ -33,6 +33,7 @@ func (t *TroubleshootKubernetesListCountPodsPerCluster) RegisterInServer(s *serv
 		),
 		mcp.WithOutputSchema[map[string]any](),
 		mcp.WithReadOnlyHintAnnotation(true),
+		mcp.WithDestructiveHintAnnotation(false),
 		WithRequiredPermissions(), // FIXME(fede): Add the required permissions. It should be `promql.exec` but somehow the token does not have that permission even if you are able to execute queries.
 	)
 	s.AddTool(tool, t.handle)
diff --git a/internal/infra/mcp/tools/tool_troubleshoot_kubernetes_list_top_400_500_http_errors_in_pods.go b/internal/infra/mcp/tools/tool_troubleshoot_kubernetes_list_top_400_500_http_errors_in_pods.go
@@ -37,6 +37,7 @@ func (t *TroubleshootKubernetesListTop400500HttpErrorsInPods) RegisterInServer(s
 		),
 		mcp.WithOutputSchema[map[string]any](),
 		mcp.WithReadOnlyHintAnnotation(true),
+		mcp.WithDestructiveHintAnnotation(false),
 		WithRequiredPermissions(), // FIXME(fede): Add the required permissions. It should be `promql.exec` but somehow the token does not have that permission even if you are able to execute queries.
 	)
 	s.AddTool(tool, t.handle)
diff --git a/internal/infra/mcp/tools/tool_troubleshoot_kubernetes_list_top_cpu_consumed_by_container.go b/internal/infra/mcp/tools/tool_troubleshoot_kubernetes_list_top_cpu_consumed_by_container.go
@@ -35,6 +35,7 @@ func (t *TroubleshootKubernetesListTopCPUConsumedByContainer) RegisterInServer(s
 		),
 		mcp.WithOutputSchema[map[string]any](),
 		mcp.WithReadOnlyHintAnnotation(true),
+		mcp.WithDestructiveHintAnnotation(false),
 		WithRequiredPermissions(), // FIXME(fede): Add the required permissions. It should be `promql.exec` but somehow the token does not have that permission even if you are able to execute queries.
 	)
 	s.AddTool(tool, t.handle)
diff --git a/internal/infra/mcp/tools/tool_troubleshoot_kubernetes_list_top_cpu_consumed_by_workload.go b/internal/infra/mcp/tools/tool_troubleshoot_kubernetes_list_top_cpu_consumed_by_workload.go
@@ -35,6 +35,7 @@ func (t *TroubleshootKubernetesListTopCPUConsumedByWorkload) RegisterInServer(s
 		),
 		mcp.WithOutputSchema[map[string]any](),
 		mcp.WithReadOnlyHintAnnotation(true),
+		mcp.WithDestructiveHintAnnotation(false),
 		WithRequiredPermissions(), // FIXME(fede): Add the required permissions. It should be `promql.exec` but somehow the token does not have that permission even if you are able to execute queries.
 	)
 	s.AddTool(tool, t.handle)
diff --git a/internal/infra/mcp/tools/tool_troubleshoot_kubernetes_list_top_memory_consumed_by_container.go b/internal/infra/mcp/tools/tool_troubleshoot_kubernetes_list_top_memory_consumed_by_container.go
@@ -35,6 +35,7 @@ func (t *TroubleshootKubernetesListTopMemoryConsumedByContainer) RegisterInServe
 		),
 		mcp.WithOutputSchema[map[string]any](),
 		mcp.WithReadOnlyHintAnnotation(true),
+		mcp.WithDestructiveHintAnnotation(false),
 		WithRequiredPermissions(), // FIXME(fede): Add the required permissions. It should be `promql.exec` but somehow the token does not have that permission even if you are able to execute queries.
 	)
 	s.AddTool(tool, t.handle)
diff --git a/internal/infra/mcp/tools/tool_troubleshoot_kubernetes_list_top_memory_consumed_by_workload.go b/internal/infra/mcp/tools/tool_troubleshoot_kubernetes_list_top_memory_consumed_by_workload.go
@@ -35,6 +35,7 @@ func (t *TroubleshootKubernetesListTopMemoryConsumedByWorkload) RegisterInServer
 		),
 		mcp.WithOutputSchema[map[string]any](),
 		mcp.WithReadOnlyHintAnnotation(true),
+		mcp.WithDestructiveHintAnnotation(false),
 		WithRequiredPermissions(), // FIXME(fede): Add the required permissions. It should be `promql.exec` but somehow the token does not have that permission even if you are able to execute queries.
 	)
 	s.AddTool(tool, t.handle)
diff --git a/internal/infra/mcp/tools/tool_troubleshoot_kubernetes_list_top_network_errors_in_pods.go b/internal/infra/mcp/tools/tool_troubleshoot_kubernetes_list_top_network_errors_in_pods.go
@@ -37,6 +37,7 @@ func (t *TroubleshootKubernetesListTopNetworkErrorsInPods) RegisterInServer(s *s
 		),
 		mcp.WithOutputSchema[map[string]any](),
 		mcp.WithReadOnlyHintAnnotation(true),
+		mcp.WithDestructiveHintAnnotation(false),
 		WithRequiredPermissions(), // FIXME(fede): Add the required permissions. It should be `promql.exec` but somehow the token does not have that permission even if you are able to execute queries.
 	)
 	s.AddTool(tool, t.handle)
diff --git a/internal/infra/mcp/tools/tool_troubleshoot_kubernetes_list_top_restarted_pods.go b/internal/infra/mcp/tools/tool_troubleshoot_kubernetes_list_top_restarted_pods.go
@@ -36,6 +36,7 @@ func (t *TroubleshootKubernetesListTopRestartedPods) RegisterInServer(s *server.
 		),
 		mcp.WithOutputSchema[map[string]any](),
 		mcp.WithReadOnlyHintAnnotation(true),
+		mcp.WithDestructiveHintAnnotation(false),
 		WithRequiredPermissions(), // FIXME(fede): Add the required permissions. It should be `promql.exec` but somehow the token does not have that permission even if you are able to execute queries.
 	)
 	s.AddTool(tool, t.handle)
diff --git a/internal/infra/mcp/tools/tool_troubleshoot_kubernetes_list_top_unavailable_pods.go b/internal/infra/mcp/tools/tool_troubleshoot_kubernetes_list_top_unavailable_pods.go
@@ -35,6 +35,7 @@ func (t *TroubleshootKubernetesListTopUnavailablePods) RegisterInServer(s *serve
 		),
 		mcp.WithOutputSchema[map[string]any](),
 		mcp.WithReadOnlyHintAnnotation(true),
+		mcp.WithDestructiveHintAnnotation(false),
 		WithRequiredPermissions(), // FIXME(fede): Add the required permissions. It should be `promql.exec` but somehow the token does not have that permission even if you are able to execute queries.
 	)
 	s.AddTool(tool, t.handle)
diff --git a/internal/infra/mcp/tools/tool_troubleshoot_kubernetes_list_underutilized_pods_by_cpu_quota.go b/internal/infra/mcp/tools/tool_troubleshoot_kubernetes_list_underutilized_pods_by_cpu_quota.go
@@ -33,6 +33,7 @@ func (t *TroubleshootKubernetesListUnderutilizedPodsByCPUQuota) RegisterInServer
 		),
 		mcp.WithOutputSchema[map[string]any](),
 		mcp.WithReadOnlyHintAnnotation(true),
+		mcp.WithDestructiveHintAnnotation(false),
 		WithRequiredPermissions(), // FIXME(fede): Add the required permissions. It should be `promql.exec` but somehow the token does not have that permission even if you are able to execute queries.
 	)
 	s.AddTool(tool, t.handle)
diff --git a/internal/infra/mcp/tools/tool_troubleshoot_kubernetes_list_underutilized_pods_by_memory_quota.go b/internal/infra/mcp/tools/tool_troubleshoot_kubernetes_list_underutilized_pods_by_memory_quota.go
@@ -33,6 +33,7 @@ func (t *TroubleshootKubernetesListUnderutilizedPodsByMemoryQuota) RegisterInSer
 		),
 		mcp.WithOutputSchema[map[string]any](),
 		mcp.WithReadOnlyHintAnnotation(true),
+		mcp.WithDestructiveHintAnnotation(false),
 		WithRequiredPermissions(), // FIXME(fede): Add the required permissions. It should be `promql.exec` but somehow the token does not have that permission even if you are able to execute queries.
 	)
 	s.AddTool(tool, t.handle)

Original file line number	Diff line number	Diff line change
`@@ -54,6 +54,7 @@ func (h ToolGenerateSysql) RegisterInServer(s server.MCPServer) {`
`54`	`54`	`),`
`55`	`55`	`mcp.WithOutputSchema[map[string]any](),`
`56`	`56`	`mcp.WithReadOnlyHintAnnotation(true),`
	`57`	`+ mcp.WithDestructiveHintAnnotation(false),`
`57`	`58`	`WithRequiredPermissions("sage.exec"),`
`58`	`59`	`)`
`59`	`60`	`s.AddTool(tool, h.handle)`
Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,7 @@ func (h ToolGetEventInfo) RegisterInServer(s server.MCPServer) {`
`44`	`44`	`),`
`45`	`45`	`mcp.WithOutputSchema[map[string]any](),`
`46`	`46`	`mcp.WithReadOnlyHintAnnotation(true),`
	`47`	`+ mcp.WithDestructiveHintAnnotation(false),`
`47`	`48`	`WithRequiredPermissions("policy-events.read"),`
`48`	`49`	`)`
`49`	`50`
Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,7 @@ func (h ToolGetEventProcessTree) RegisterInServer(s server.MCPServer) {`
`62`	`62`	`),`
`63`	`63`	`mcp.WithOutputSchema[map[string]any](),`
`64`	`64`	`mcp.WithReadOnlyHintAnnotation(true),`
	`65`	`+ mcp.WithDestructiveHintAnnotation(false),`
`65`	`66`	`WithRequiredPermissions("policy-events.read"),`
`66`	`67`	`)`
`67`	`68`
Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,7 @@ func (t KubernetesListClusters) RegisterInServer(s server.MCPServer) {`
`31`	`31`	`),`
`32`	`32`	`mcp.WithOutputSchema[map[string]any](),`
`33`	`33`	`mcp.WithReadOnlyHintAnnotation(true),`
	`34`	`+ mcp.WithDestructiveHintAnnotation(false),`
`34`	`35`	WithRequiredPermissions(), // FIXME(fede): Add the required permissions. It should be `promql.exec` but somehow the token does not have that permission even if you are able to execute queries.
`35`	`36`	`)`
`36`	`37`	`s.AddTool(tool, t.handle)`
Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,7 @@ func (t KubernetesListCronjobs) RegisterInServer(s server.MCPServer) {`
`34`	`34`	`),`
`35`	`35`	`mcp.WithOutputSchema[map[string]any](),`
`36`	`36`	`mcp.WithReadOnlyHintAnnotation(true),`
	`37`	`+ mcp.WithDestructiveHintAnnotation(false),`
`37`	`38`	WithRequiredPermissions(), // FIXME(fede): Add the required permissions. It should be `promql.exec` but somehow the token does not have that permission even if you are able to execute queries.
`38`	`39`	`)`
`39`	`40`	`s.AddTool(tool, t.handle)`
Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,7 @@ func (t KubernetesListNodes) RegisterInServer(s server.MCPServer) {`
`33`	`33`	`),`
`34`	`34`	`mcp.WithOutputSchema[map[string]any](),`
`35`	`35`	`mcp.WithReadOnlyHintAnnotation(true),`
	`36`	`+ mcp.WithDestructiveHintAnnotation(false),`
`36`	`37`	WithRequiredPermissions(), // FIXME(fede): Add the required permissions. It should be `promql.exec` but somehow the token does not have that permission even if you are able to execute queries.
`37`	`38`	`)`
`38`	`39`	`s.AddTool(tool, t.handle)`
Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,7 @@ func (t KubernetesListPodContainers) RegisterInServer(s server.MCPServer) {`
`39`	`39`	`),`
`40`	`40`	`mcp.WithOutputSchema[map[string]any](),`
`41`	`41`	`mcp.WithReadOnlyHintAnnotation(true),`
	`42`	`+ mcp.WithDestructiveHintAnnotation(false),`
`42`	`43`	WithRequiredPermissions(), // FIXME(fede): Add the required permissions. It should be `promql.exec` but somehow the token does not have that permission even if you are able to execute queries.
`43`	`44`	`)`
`44`	`45`	`s.AddTool(tool, t.handle)`
Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,7 @@ func (t KubernetesListWorkloads) RegisterInServer(s server.MCPServer) {`
`43`	`43`	`),`
`44`	`44`	`mcp.WithOutputSchema[map[string]any](),`
`45`	`45`	`mcp.WithReadOnlyHintAnnotation(true),`
	`46`	`+ mcp.WithDestructiveHintAnnotation(false),`
`46`	`47`	WithRequiredPermissions(), // FIXME(fede): Add the required permissions. It should be `promql.exec` but somehow the token does not have that permission even if you are able to execute queries.
`47`	`48`	`)`
`48`	`49`	`s.AddTool(tool, t.handle)`
Original file line number	Diff line number	Diff line change
`@@ -100,6 +100,7 @@ You can specify the severity of the events based on the following cases:`
`100`	`100`	`),`
`101`	`101`	`mcp.WithOutputSchema[map[string]any](),`
`102`	`102`	`mcp.WithReadOnlyHintAnnotation(true),`
	`103`	`+ mcp.WithDestructiveHintAnnotation(false),`
`103`	`104`	`WithRequiredPermissions("policy-events.read"),`
`104`	`105`	`)`
`105`	`106`
Original file line number	Diff line number	Diff line change
`@@ -61,6 +61,7 @@ func (h ToolRunSysql) RegisterInServer(s server.MCPServer) {`
`61`	`61`	`),`
`62`	`62`	`mcp.WithOutputSchema[map[string]any](),`
`63`	`63`	`mcp.WithReadOnlyHintAnnotation(true),`
	`64`	`+ mcp.WithDestructiveHintAnnotation(false),`
`64`	`65`	`WithRequiredPermissions("sage.exec", "risks.read"),`
`65`	`66`	`)`
`66`	`67`	`s.AddTool(tool, h.handle)`