refactor: remove scanning module (#49)

* refactor: remove scanning module

Author: iru

.github/workflows/ci-integration-tests.yaml

@@ -53,8 +53,6 @@ jobs:
           kubectl get deployments -n sfc-tests-kitchen-singlek8s
           kubectl describe deployment cloud-connector -n sfc-tests-kitchen-singlek8s
           kubectl logs deployment.apps/cloud-connector -n sfc-tests-kitchen-singlek8s
-          kubectl logs deployment.apps/cloud-scanning -n sfc-tests-kitchen-singlek8s
-
 
       - name: Destroy single-account-k8s resources
         env:
@@ -85,8 +83,6 @@ jobs:
           kubectl get deployments -n sfc-tests-kitchen-singlek8s
           kubectl describe deployment cloud-connector -n sfc-tests-kitchen-orgk8s
           kubectl logs deployment.apps/cloud-connector -n sfc-tests-kitchen-orgk8s
-          kubectl logs deployment.apps/cloud-scanning -n sfc-tests-kitchen-orgk8s
-
 
       - name: Destroy org-k8s test
         env:

.pre-commit-config.yaml

@@ -23,6 +23,7 @@ repos:
     rev: v1.50.0
     hooks:
       - id: terraform_fmt
+#      - id: terraform_validate
       - id: terraform_docs
         args:
           - '--args=--sort-by required'

examples-internal/single-account-scanning/main.tf

@@ -5,11 +5,11 @@ The aim of this module is to manage the organizational **managed account** requi
 1. Enables Cloudtrail SNS subscription permissions through a role specified within the Sysdig Secure workload **member account**
 2. Creates a role in the organizational **managed account** with the required permissions
 
-* Threat-Detection through [cloud-connector](https://github.com/sysdiglabs/terraform-aws-secure-for-cloud/tree/master/modules/services/cloud-connector).
+* Threat-Detection
   * S3 Get and List permissions in order to fetch the events
   * SNS Subscription permissions in order to subscribe a topic to it
 
-* Image scanning through [cloud-scanning](https://github.com/sysdiglabs/terraform-aws-secure-for-cloud/tree/master/modules/services/cloud-scanning).
+* Image scanning
   * Enable this role to assumeRole to member accounts through the `organizational_role_per_account` role,
     in order to be able to fetch images that may be in member-account repositories
 

examples-internal/single-account-scanning/outputs.tf

@@ -5,11 +5,11 @@ The aim of this module is to manage the organizational **managed account** requi
 1. Enables Cloudtrail SNS subscription permissions through a role specified within the Sysdig Secure workload **member account**
 2. Creates a role in the organizational **managed account** with the required permissions
 
-* Threat-Detection through [cloud-connector](https://github.com/sysdiglabs/terraform-aws-secure-for-cloud/tree/master/modules/services/cloud-connector).
+* Threat-Detection
   * S3 Get and List permissions in order to fetch the events
   * SNS Subscription permissions in order to subscribe a topic to it
 
-* Image scanning through [cloud-scanning](https://github.com/sysdiglabs/terraform-aws-secure-for-cloud/tree/master/modules/services/cloud-scanning).
+* Image scanning
   * Enable this role to assumeRole to member accounts through the `organizational_role_per_account` role,
     in order to be able to fetch images that may be in member-account repositories
 

examples-internal/single-account-scanning/variables.tf

@@ -1,6 +1,6 @@
 # Permissions :: General
 
-General permissions that apply to both cloud-connector and cloud-scanning modules
+General permissions that apply to both threat-detection (cloud-connector) and image-scanning (cloud-scanning) features
 
 <!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
 ## Requirements