SSPROD-58177 - fix: update var deprecation (#77)

* SSPROD-58177 - fix: update var deprecation

* SSPROD-58177 - fix: update var deprecation

Author: jose-pablo-camacho

modules/agentless-scanning/main.tf

@@ -311,7 +311,7 @@ TEMPLATE
 # stackset instance to deploy resources for agentless scanning, in all regions of given account
 resource "aws_cloudformation_stack_set_instance" "primary_acc_stackset_instance" {
   for_each = local.region_set
-  region   = each.key
+  stack_set_instance_region   = each.key
 
   stack_set_name = aws_cloudformation_stack_set.primary_acc_stackset.name
   operation_preferences {

modules/agentless-scanning/organizational.tf

@@ -188,7 +188,7 @@ resource "aws_cloudformation_stack_set_instance" "ou_stackset_instance" {
     "${pair[0]}-${pair[1]}" => pair
   } : {}
 
-  region         = each.value[0]
+  stack_set_instance_region         = each.value[0]
   stack_set_name = aws_cloudformation_stack_set.ou_resources_stackset[0].name
   deployment_targets {
     organizational_unit_ids = [each.value[1]]

modules/config-posture/organizational.tf

@@ -106,7 +106,7 @@ TEMPLATE
 resource "aws_cloudformation_stack_set_instance" "stackset_instance" {
   for_each = var.is_organizational ? toset(local.deployment_targets_org_units) : []
 
-  region         = var.region == "" ? null : var.region
+  stack_set_instance_region = var.region == "" ? null : var.region
   stack_set_name = aws_cloudformation_stack_set.stackset[0].name
   deployment_targets {
     organizational_unit_ids = [each.value]

modules/integrations/cloud-logs/main.tf

@@ -278,8 +278,8 @@ resource "aws_cloudformation_stack_set_instance" "cloudlogs_s3_access_bucket" {
     account_filter_type = "INTERSECTION"
     accounts = [local.bucket_account_id]
   }
-  
-  region = data.aws_region.current.name
+
+  stack_set_instance_region = data.aws_region.current.name
 
   timeouts {
     create = var.timeout
@@ -299,8 +299,8 @@ resource "aws_cloudformation_stack_set_instance" "cloudlogs_s3_access_topic" {
     account_filter_type = "INTERSECTION"
     accounts = [local.topic_account_id]
   }
-  
-  region = local.topic_region
+
+  stack_set_instance_region = local.topic_region
 
   timeouts {
     create = var.timeout

modules/integrations/event-bridge/main.tf

@@ -252,7 +252,7 @@ resource "aws_cloudformation_stack_set" "eb_rule_and_api_dest_stackset" {
 
 resource "aws_cloudformation_stack_set_instance" "eb_rule_and_api_dest_stackset_instance" {
   for_each       = local.region_set
-  region         = each.key
+  stack_set_instance_region = each.key
   stack_set_name = aws_cloudformation_stack_set.eb_rule_and_api_dest_stackset.name
 
   operation_preferences {

modules/integrations/event-bridge/organizational.tf

@@ -70,7 +70,7 @@ resource "aws_cloudformation_stack_set_instance" "eb_rule_api_dest_instance" {
     "${pair[0]}-${pair[1]}" => pair
   } : {}
 
-  region         = each.value[0]
+  stack_set_instance_region         = each.value[0]
   stack_set_name = aws_cloudformation_stack_set.eb_rule_api_dest_stackset[0].name
   deployment_targets {
     organizational_unit_ids = [each.value[1]]

modules/onboarding/organizational.tf

@@ -56,7 +56,7 @@ TEMPLATE
 resource "aws_cloudformation_stack_set_instance" "stackset_instance" {
   for_each = var.is_organizational ? toset(local.deployment_targets_org_units) : []
 
-  region         = var.region == "" ? null : var.region
+  stack_set_instance_region = var.region == "" ? null : var.region
   stack_set_name = aws_cloudformation_stack_set.stackset[0].name
   deployment_targets {
     organizational_unit_ids = [each.value]