Skip to content

Commit 9d48337

Browse files
Make external_id a required var in webhook-datasource module (#26)
Change summary: ---------------- The external_id variable was made optional so as to not break onboarding backend. In the backend, we always ensure passing the external_id to the module, because if not provided, the validation for the same would fail via WIF. Making this required now (as it should be) since backend is all merged.
1 parent 6c1ca9f commit 9d48337

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

modules/services/webhook-datasource/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ No modules.
7070
| <a name="input_project_id"></a> [project\_id](#input\_project\_id) | (Required) Target Project identifier provided by the customer | `string` | n/a | yes |
7171
| <a name="input_push_endpoint"></a> [push\_endpoint](#input\_push\_endpoint) | (Required) Final endpoint towards which audit logs POST calls will be directed | `string` | n/a | yes |
7272
| <a name="input_role_name"></a> [role\_name](#input\_role\_name) | (Optional) Role name for custom role binding to the service account, with read permissions for data ingestion resources | `string` | `"SysdigIngestionAuthRole"` | no |
73-
| <a name="input_external_id"></a> [external\_id](#input\_external\_id) | (Optional) Random string generated unique to a customer | `string` | `""` | no |
73+
| <a name="input_external_id"></a> [external\_id](#input\_external\_id) | (Required) Random string generated unique to a customer | `string` | n/a | yes |
7474
| <a name="input_suffix"></a> [suffix](#input\_suffix) | (Optional) Suffix to uniquely identify resources during multiple installs. If not provided, random value is autogenerated | `string` | `null` | no |
7575

7676
## Outputs

modules/services/webhook-datasource/variables.tf

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,7 @@ variable "role_name" {
6666

6767
variable "external_id" {
6868
type = string
69-
description = "Random string generated unique to a customer"
70-
default = ""
69+
description = "(Required) Random string generated unique to a customer"
7170
}
7271

7372
variable "suffix" {

0 commit comments

Comments
 (0)