fix(lint): solve linter problems

Author: tembleking

flake.nix

@@ -43,6 +43,8 @@
               packages = [
                 go_1_23
                 govulncheck
+                golangci-lint
+                golangci-lint-langserver
               ];
             };
 
@@ -58,6 +60,7 @@
             mkShell {
               packages = [
                 (terraform.withPlugins (tf: [ tf.sysdig ]))
+                bashInteractive
               ];
             };
 

sysdig/common_test.go

@@ -4,8 +4,6 @@ import (
 	"os"
 	"strings"
 	"testing"
-
-	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/acctest"
 )
 
 const (
@@ -31,17 +29,3 @@ func preCheckAnyEnv(t *testing.T, envs ...string) func() {
 		}
 	}
 }
-
-func sysdigOrIBMMonitorPreCheck(t *testing.T) func() {
-	return func() {
-		monitor := os.Getenv("SYSDIG_MONITOR_API_TOKEN")
-		ibmMonitor := os.Getenv("SYSDIG_IBM_MONITOR_API_KEY")
-		if monitor == "" && ibmMonitor == "" {
-			t.Fatal("SYSDIG_MONITOR_API_TOKEN or SYSDIG_IBM_MONITOR_API_KEY must be set for acceptance tests")
-		}
-	}
-}
-
-func randomText(len int) string {
-	return acctest.RandStringFromCharSet(len, acctest.CharSetAlphaNum)
-}

sysdig/resource_sysdig_monitor_team_shared_test.go

@@ -255,30 +255,30 @@ func resourceSysdigSecureVulnerabilityAcceptRiskRead(ctx context.Context, d *sch
 	if err != nil {
 		return diag.FromErr(err)
 	}
-	d.Set("reason", result.Reason)
-	d.Set("description", result.Description)
+	_ = d.Set("reason", result.Reason)
+	_ = d.Set("description", result.Description)
 	if result.ExpirationDate != "" {
-		d.Set("expiration_date", result.ExpirationDate)
+		_ = d.Set("expiration_date", result.ExpirationDate)
 	}
-	d.Set("stages", result.Stages)
+	_ = d.Set("stages", result.Stages)
 	switch result.EntityType {
 	case v2.EntityTypeImageName:
-		d.Set("image", result.EntityValue)
+		_ = d.Set("image", result.EntityValue)
 	case v2.EntityTypeImagePrefix:
-		d.Set("image", result.EntityValue+"*")
+		_ = d.Set("image", result.EntityValue+"*")
 	case v2.EntityTypeImageSuffix:
-		d.Set("image", "*"+result.EntityValue)
+		_ = d.Set("image", "*"+result.EntityValue)
 	case v2.EntityTypeImageNameContains:
-		d.Set("image", "*"+result.EntityValue+"*")
+		_ = d.Set("image", "*"+result.EntityValue+"*")
 	case v2.EntityTypeVulnerability:
-		d.Set("cve", result.EntityValue)
+		_ = d.Set("cve", result.EntityValue)
 		fillResourceDataFromContextSlice(d, result.Context)
 	case v2.EntityTypeHostName:
-		d.Set("hostname", result.EntityValue)
+		_ = d.Set("hostname", result.EntityValue)
 	case v2.EntityTypeHostNameContains:
-		d.Set("hostname_contains", result.EntityValue)
+		_ = d.Set("hostname_contains", result.EntityValue)
 	case v2.EntityTypePolicyRule:
-		d.Set("rule_id", result.EntityValue)
+		_ = d.Set("rule_id", result.EntityValue)
 		fillResourceDataFromContextSlice(d, result.Context)
 	default:
 		panic(fmt.Sprintf("unexpected v2.EntityType: %#v", result.EntityType))
@@ -295,21 +295,21 @@ func fillResourceDataFromContextSlice(d *schema.ResourceData, contextSlice []v2.
 func fillResourceDataFromContext(d *schema.ResourceData, context v2.AcceptVulnerabilityRiskContext) {
 	switch context.ContextType {
 	case v2.ContextTypeHostName:
-		d.Set("hostname", context.ContextValue)
+		_ = d.Set("hostname", context.ContextValue)
 	case v2.ContextTypeHostNameContains:
-		d.Set("hostname_contains", context.ContextValue)
+		_ = d.Set("hostname_contains", context.ContextValue)
 	case v2.ContextTypeImageName:
-		d.Set("image", context.ContextValue)
+		_ = d.Set("image", context.ContextValue)
 	case v2.ContextTypeImageNameContains:
-		d.Set("image", "*"+context.ContextValue+"*")
+		_ = d.Set("image", "*"+context.ContextValue+"*")
 	case v2.ContextTypeImagePrefix:
-		d.Set("image", context.ContextValue+"*")
+		_ = d.Set("image", context.ContextValue+"*")
 	case v2.ContextTypeImageSuffix:
-		d.Set("image", "*"+context.ContextValue)
+		_ = d.Set("image", "*"+context.ContextValue)
 	case v2.ContextTypePackageName:
-		d.Set("package_name", context.ContextValue)
+		_ = d.Set("package_name", context.ContextValue)
 	case v2.ContextTypePackageVersion:
-		d.Set("package_version", context.ContextValue)
+		_ = d.Set("package_version", context.ContextValue)
 	default:
 		panic(fmt.Sprintf("unexpected v2.ContextType: %#v", context.ContextType))
 	}