Add role_name to cloud account resource (#121)

* add role name to cloud account resource

* fix readme

* fix cloud acc readme

* make fmt

Author: Alexander Qiu

sysdig/internal/client/secure/models.go

@@ -368,6 +368,7 @@ type CloudAccount struct {
 	Provider      string `json:"provider"`
 	Alias         string `json:"alias"`
 	RoleAvailable bool   `json:"roleAvailable"`
+	RoleName      string `json:"roleName"`
 	ExternalID    string `json:"externalId,omitempty"`
 }
 

sysdig/resource_sysdig_secure_cloud_account.go

@@ -47,6 +47,11 @@ func resourceSysdigSecureCloudAccount() *schema.Resource {
 				Optional: true,
 				Default:  false,
 			},
+			"role_name": {
+				Type:     schema.TypeString,
+				Optional: true,
+				Default:  "SysdigCloudBench",
+			},
 			"external_id": {
 				Type:     schema.TypeString,
 				Computed: true,
@@ -71,6 +76,7 @@ func resourceSysdigSecureCloudAccountCreate(ctx context.Context, d *schema.Resou
 	d.Set("cloud_provider", cloudAccount.Provider)
 	d.Set("alias", cloudAccount.Alias)
 	d.Set("role_enabled", cloudAccount.RoleAvailable)
+	d.Set("role_name", cloudAccount.RoleName)
 	d.Set("external_id", cloudAccount.ExternalID)
 
 	return nil
@@ -93,6 +99,7 @@ func resourceSysdigSecureCloudAccountRead(ctx context.Context, d *schema.Resourc
 	d.Set("cloud_provider", cloudAccount.Provider)
 	d.Set("alias", cloudAccount.Alias)
 	d.Set("role_enabled", cloudAccount.RoleAvailable)
+	d.Set("role_name", cloudAccount.RoleName)
 	d.Set("external_id", cloudAccount.ExternalID)
 
 	return nil
@@ -131,5 +138,6 @@ func cloudAccountFromResourceData(d *schema.ResourceData) *secure.CloudAccount {
 		Provider:      d.Get("cloud_provider").(string),
 		Alias:         d.Get("alias").(string),
 		RoleAvailable: d.Get("role_enabled").(bool),
+		RoleName:      d.Get("role_name").(string),
 	}
 }

sysdig/resource_sysdig_secure_cloud_account_test.go

@@ -49,6 +49,7 @@ resource "sysdig_secure_cloud_account" "sample" {
   cloud_provider      = "aws"
   alias               = "%s"
   role_enabled        = "false"
+  role_name            = "CustomRoleName"
 }
 `, accountID, accountID)
 }

website/docs/r/sysdig_secure_cloud_account.md

@@ -3,7 +3,7 @@ layout: "sysdig"
 page_title: "Sysdig: sysdig_secure_cloud_account"
 sidebar_current: "docs-sysdig_secure_cloud_account"
 description: |-
-  Creates a Sysdig Secure Cloud Account.
+Creates a Sysdig Secure Cloud Account.
 ---
 
 # sysdig\_secure\_cloud_account
@@ -20,18 +20,21 @@ resource "sysdig_secure_cloud_account" "sample" {
   cloud_provider      = "aws"
   alias               = "prod"
   role_enabled        = "false"
+  role_name           = "CustomRoleName"
 }
 ```
 
 ## Argument Reference
 
-* `account_id` - (Required) The unique identifier of the cloud account. e.g. for AWS: `123456789012`, 
+* `account_id` - (Required) The unique identifier of the cloud account. e.g. for AWS: `123456789012`,
 
 * `cloud_provider` - (Required) The cloud provider in which the account exists. Currently supported providers are `aws`, `gcp` and `azure`
 
 * `alias` - (Optional) A human friendly alias for `account_id`.
 
-* `role_enabled` - (Optional) Whether or not a role with the name `SysdigCloud` is provisioned withing this account, that Sysdig has permission to AssumeRole in order to run Benchmarks. Default: `false`.
+* `role_enabled` - (Optional) Whether or not a role is provisioned withing this account, that Sysdig has permission to AssumeRole in order to run Benchmarks. Default: `false`.
+
+* `role_name` - (Optional) The name of the role Sysdig will have permission to AssumeRole if `role_enaled` is set to `true`. Default: `SysdigCloudBench`.
 
 ## Import