fix: Solve crash when importing unsupported dashboard panels (#73)

* fix: Solve crash when importing unsupported dashboard
* docs: Add unsupported panel message while importing

Author: tembleking

sysdig/resource_sysdig_monitor_dashboard.go

@@ -2,6 +2,7 @@ package sysdig
 
 import (
 	"context"
+	"fmt"
 	"github.com/draios/terraform-provider-sysdig/sysdig/monitor/model"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
@@ -228,7 +229,7 @@ func panelsFromResourceData(data *schema.ResourceData) (panels []*model.Panels,
 		case "number":
 			panelType = model.PanelTypeNumber
 		default:
-			panic("unreachable code")
+			return nil, fmt.Errorf("unsupported panel type %s", panelInfo["type"])
 		}
 
 		panel := model.NewPanel(panelInfo["name"].(string), panelInfo["description"].(string), panelType)
@@ -238,7 +239,11 @@ func panelsFromResourceData(data *schema.ResourceData) (panels []*model.Panels,
 			return nil, err
 		}
 
-		queries := queriesFromResourceData(panelInfo, panel)
+		queries, err := queriesFromResourceData(panelInfo, panel)
+		if err != nil {
+			return nil, err
+		}
+
 		_, err = panel.AddQueries(queries...)
 		if err != nil {
 			return nil, err
@@ -249,7 +254,7 @@ func panelsFromResourceData(data *schema.ResourceData) (panels []*model.Panels,
 	return
 }
 
-func queriesFromResourceData(panelInfo map[string]interface{}, panel *model.Panels) (newQueries []*model.AdvancedQueries) {
+func queriesFromResourceData(panelInfo map[string]interface{}, panel *model.Panels) (newQueries []*model.AdvancedQueries, err error) {
 	for _, queryItr := range panelInfo["query"].(*schema.Set).List() {
 		queryInfo := queryItr.(map[string]interface{})
 
@@ -269,7 +274,7 @@ func queriesFromResourceData(panelInfo map[string]interface{}, panel *model.Pane
 		case "time":
 			promqlQuery.WithTimeFormat()
 		default:
-			panic("unreachable code")
+			return nil, fmt.Errorf("unsupported query format unit: %s", queryInfo["unit"])
 		}
 
 		newQueries = append(newQueries, promqlQuery)
@@ -302,7 +307,7 @@ func dashboardToResourceData(dashboard *model.Dashboard, data *schema.ResourceDa
 			case model.FormatUnitTime:
 				unit = "time"
 			default:
-				panic("unreachable code")
+				return fmt.Errorf("unsupported query format unit: %s", query.Format.Unit)
 			}
 
 			queries = append(queries, map[string]interface{}{
@@ -326,7 +331,7 @@ func dashboardToResourceData(dashboard *model.Dashboard, data *schema.ResourceDa
 		case model.PanelTypeNumber:
 			panelType = "number"
 		default:
-			panic("unreachable code")
+			return fmt.Errorf("unsupported panel type %s", panel.Type)
 		}
 
 		panels = append(panels, map[string]interface{}{

website/docs/r/sysdig_monitor_dashboard.md

@@ -119,4 +119,16 @@ Monitor dashboards can be imported using the dashboard ID, e.g.
 
 ```
 $ terraform import sysdig_monitor_dashboard.example 12345
-```
+```
+
+Only dashboards that contain supported panels can be imported. Currently supported panel types are:
+- PromQL timecharts
+- PromQL numbers
+
+Only dashboards that contain supported query types can be imported. Currently supported query types:
+- Percent
+- Data
+- Data rate
+- Number
+- Number rate
+- Time