Skip to content

Commit 56bcf38

Browse files
committed
fix(tests): update deprecated trigger_after_minutes
Replaces the deprecated 'trigger_after_minutes' field with its correct counterparts ('duration_seconds' or 'range_seconds') across multiple alert test files. This change aligns the tests with the recent removal of the deprecated field, ensuring that the test suite passes and reflects the current resource schemas.
1 parent bf60623 commit 56bcf38

5 files changed

+20
-20
lines changed

sysdig/resource_sysdig_monitor_alert_v2_downtime_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ resource "sysdig_monitor_alert_v2_downtime" "sample" {
8080
values = ["thom-cluster1", "demo-env-prom"]
8181
}
8282
83-
trigger_after_minutes = 15
83+
range_seconds = 900
8484
8585
}
8686

sysdig/resource_sysdig_monitor_alert_v2_event_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ resource "sysdig_monitor_alert_v2_event" "sample" {
8585
values = ["thom-cluster1", "demo-env-prom"]
8686
}
8787
88-
trigger_after_minutes = 15
88+
range_seconds = 900
8989
9090
}
9191

sysdig/resource_sysdig_monitor_alert_v2_metric_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ resource "sysdig_monitor_alert_v2_metric" "sample" {
122122
time_aggregation = "avg"
123123
operator = ">="
124124
threshold = 50
125-
trigger_after_minutes = 15
125+
range_seconds = 900
126126
127127
}
128128
`, name)
@@ -266,7 +266,7 @@ resource "sysdig_monitor_alert_v2_metric" "sample" {
266266
time_aggregation = "avg"
267267
operator = ">="
268268
threshold = 50
269-
trigger_after_minutes = 15
269+
range_seconds = 900
270270
severity = "info"
271271
272272
}
@@ -517,7 +517,7 @@ resource "sysdig_monitor_alert_v2_metric" "sample" {
517517
time_aggregation = "avg"
518518
operator = ">="
519519
threshold = 50
520-
trigger_after_minutes = 15
520+
range_seconds = 900
521521
labels = {
522522
application = "app1"
523523
maturity = "high"

sysdig/resource_sysdig_monitor_alert_v2_prometheus_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ resource "sysdig_monitor_alert_v2_prometheus" "sample" {
6565
description = "TERRAFORM TEST - PROMQL %s"
6666
severity = "high"
6767
query = "(elasticsearch_jvm_memory_used_bytes{area=\"heap\"} / elasticsearch_jvm_memory_max_bytes{area=\"heap\"}) * 100 > 80"
68-
trigger_after_minutes = 10
68+
duration_seconds = 600
6969
enabled = false
7070
}
7171
`, name, name)

sysdig/resource_sysdig_monitor_silence_rule_test.go

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -73,39 +73,39 @@ resource "sysdig_monitor_silence_rule" "sample1" {
7373

7474
func monitorSilenceRuleWithAlertIds(name string) string {
7575
return fmt.Sprintf(`
76-
resource "sysdig_monitor_alert_promql" "sample1" {
76+
resource "sysdig_monitor_alert_v2_prometheus" "sample1" {
7777
name = "TERRAFORM TEST - PROMQL %s 1"
78-
promql = "up"
79-
trigger_after_minutes = 1
78+
query = "up"
79+
duration_seconds = 60
8080
enabled = false
8181
}
82-
resource "sysdig_monitor_alert_promql" "sample2" {
82+
resource "sysdig_monitor_alert_v2_prometheus" "sample2" {
8383
name = "TERRAFORM TEST - PROMQL %s 2"
84-
promql = "up"
85-
trigger_after_minutes = 1
84+
query = "up"
85+
duration_seconds = 60
8686
enabled = false
8787
}
8888
resource "sysdig_monitor_silence_rule" "sample2" {
8989
name = "Example Silence Rule %s"
9090
enabled = false
9191
start_ts = 1691168134153
9292
duration_seconds = 3600
93-
alert_ids = [ sysdig_monitor_alert_promql.sample1.id, sysdig_monitor_alert_promql.sample2.id ]
93+
alert_ids = [ sysdig_monitor_alert_v2_prometheus.sample1.id, sysdig_monitor_alert_v2_prometheus.sample2.id ]
9494
}`, name, name, name)
9595
}
9696

9797
func monitorSilenceRuleWithAlertIdsAndScope(name string) string {
9898
return fmt.Sprintf(`
99-
resource "sysdig_monitor_alert_promql" "sample3" {
99+
resource "sysdig_monitor_alert_v2_prometheus" "sample3" {
100100
name = "TERRAFORM TEST - PROMQL %s 3"
101-
promql = "up"
102-
trigger_after_minutes = 1
101+
query = "up"
102+
duration_seconds = 60
103103
enabled = false
104104
}
105-
resource "sysdig_monitor_alert_promql" "sample4" {
105+
resource "sysdig_monitor_alert_v2_prometheus" "sample4" {
106106
name = "TERRAFORM TEST - PROMQL %s 4"
107-
promql = "up"
108-
trigger_after_minutes = 1
107+
query = "up"
108+
duration_seconds = 60
109109
enabled = false
110110
}
111111
resource "sysdig_monitor_silence_rule" "sample3" {
@@ -114,7 +114,7 @@ resource "sysdig_monitor_silence_rule" "sample3" {
114114
start_ts = 1691168134153
115115
duration_seconds = 3600
116116
scope = "container.name in (\"test\")"
117-
alert_ids = [ sysdig_monitor_alert_promql.sample3.id, sysdig_monitor_alert_promql.sample4.id ]
117+
alert_ids = [ sysdig_monitor_alert_v2_prometheus.sample3.id, sysdig_monitor_alert_v2_prometheus.sample4.id ]
118118
}`, name, name, name)
119119
}
120120

0 commit comments

Comments
 (0)