address comments

Author: dbonf

sysdig/data_source_sysdig_monitor_notification_channel_slack.go

@@ -29,7 +29,7 @@ func dataSourceSysdigMonitorNotificationChannelSlack() *schema.Resource {
 				Type:     schema.TypeString,
 				Computed: true,
 			},
-			"private_channel": {
+			"is_private_channel": {
 				Type:     schema.TypeBool,
 				Computed: true,
 			},

sysdig/data_source_sysdig_secure_notification_channel_slack.go

@@ -29,7 +29,7 @@ func dataSourceSysdigSecureNotificationChannelSlack() *schema.Resource {
 				Type:     schema.TypeString,
 				Computed: true,
 			},
-			"private_channel": {
+			"is_private_channel": {
 				Type:     schema.TypeBool,
 				Computed: true,
 			},

sysdig/resource_sysdig_monitor_notification_channel_slack.go

@@ -40,7 +40,7 @@ func resourceSysdigMonitorNotificationChannelSlack() *schema.Resource {
 				Type:     schema.TypeString,
 				Required: true,
 			},
-			"private_channel": {
+			"is_private_channel": {
 				Type:     schema.TypeBool,
 				Optional: true,
 				Default:  false,
@@ -204,7 +204,7 @@ func monitorNotificationChannelSlackFromResourceData(d *schema.ResourceData, tea
 	nc.Type = NOTIFICATION_CHANNEL_TYPE_SLACK
 	nc.Options.Url = d.Get("url").(string)
 	nc.Options.Channel = d.Get("channel").(string)
-	nc.Options.PrivateChannel = d.Get("private_channel").(bool)
+	nc.Options.PrivateChannel = d.Get("is_private_channel").(bool)
 	nc.Options.PrivateChannelUrl = d.Get("private_channel_url").(string)
 	nc.Options.TemplateConfiguration = []v2.NotificationChannelTemplateConfiguration{
 		{
@@ -257,7 +257,7 @@ func monitorNotificationChannelSlackToResourceData(nc *v2.NotificationChannel, d
 
 	_ = d.Set("url", nc.Options.Url)
 	_ = d.Set("channel", nc.Options.Channel)
-	_ = d.Set("private_channel", nc.Options.PrivateChannel)
+	_ = d.Set("is_private_channel", nc.Options.PrivateChannel)
 	_ = d.Set("private_channel_url", nc.Options.PrivateChannelUrl)
 
 	runbookLinks := true

sysdig/resource_sysdig_monitor_notification_channel_slack_test.go

@@ -106,7 +106,7 @@ resource "sysdig_monitor_notification_channel_slack" "sample-slack-private" {
 	enabled = true
 	url = "https://hooks.slack.com/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
 	channel = "#sysdig"
-	private_channel = true
+	is_private_channel = true
 	private_channel_url = "https://app.slack.com/client/XXXXXXXX/XXXXXXXX"
 }`, name)
 }

sysdig/resource_sysdig_secure_notification_channel_slack.go

@@ -41,7 +41,7 @@ func resourceSysdigSecureNotificationChannelSlack() *schema.Resource {
 				Type:     schema.TypeString,
 				Required: true,
 			},
-			"private_channel": {
+			"is_private_channel": {
 				Type:     schema.TypeBool,
 				Optional: true,
 				Default:  false,
@@ -174,7 +174,7 @@ func secureNotificationChannelSlackFromResourceData(d *schema.ResourceData, team
 	nc.Type = NOTIFICATION_CHANNEL_TYPE_SLACK
 	nc.Options.Url = d.Get("url").(string)
 	nc.Options.Channel = d.Get("channel").(string)
-	nc.Options.PrivateChannel = d.Get("private_channel").(bool)
+	nc.Options.PrivateChannel = d.Get("is_private_channel").(bool)
 	nc.Options.PrivateChannelUrl = d.Get("private_channel_url").(string)
 
 	setNotificationChannelSlackTemplateConfig(&nc, d)
@@ -221,7 +221,7 @@ func secureNotificationChannelSlackToResourceData(nc *v2.NotificationChannel, d
 
 	_ = d.Set("url", nc.Options.Url)
 	_ = d.Set("channel", nc.Options.Channel)
-	_ = d.Set("private_channel", nc.Options.PrivateChannel)
+	_ = d.Set("is_private_channel", nc.Options.PrivateChannel)
 	_ = d.Set("private_channel_url", nc.Options.PrivateChannelUrl)
 
 	err = getTemplateVersionFromNotificationChannelSlack(nc, d)

sysdig/resource_sysdig_secure_notification_channel_slack_test.go

@@ -105,7 +105,7 @@ resource "sysdig_secure_notification_channel_slack" "sample-slack-private" {
 	enabled = true
 	url = "https://hooks.slack.com/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
 	channel = "#sysdig"
-	private_channel = true
+	is_private_channel = true
 	private_channel_url = "https://app.slack.com/client/XXXXXXXX/XXXXXXXX"
 }`, name)
 }

website/docs/d/monitor_notification_channel_slack.md

@@ -31,7 +31,7 @@ In addition to all arguments above, the following attributes are exported:
 * `id` - The Notification Channel ID.
 * `url` - URL of the Slack webhook.
 * `channel` - Name of the Slack channel.
-* `private_channel` - Whether the Slack Channel has been marked as private or not.
+* `is_private_channel` - Whether the Slack Channel has been marked as private or not.
 * `private_channel_url` - The channel URL, i.e. the link that is referencing the channel (not to be confused with the webhook url), if the channel is private.
 * `show_section_runbook_links` - Whether to include the runbook links section in the Slack messages.
 * `show_section_event_details` - Whether to include the event details section in the Slack messages.

website/docs/d/secure_notification_channel_slack.md

@@ -31,7 +31,7 @@ In addition to all arguments above, the following attributes are exported:
 * `id` - The Notification Channel ID.
 * `url` - URL of the Slack webhook.
 * `channel` - Name of the Slack channel.
-* `private_channel` - Whether the Slack Channel has been marked as private or not.
+* `is_private_channel` - Whether the Slack Channel has been marked as private or not.
 * `private_channel_url` - The channel URL, i.e. the link that is referencing the channel (not to be confused with the webhook url), if the channel is private.
 * `template_version` - The notification template version to use to create notifications.
 * `enabled` - Whether the Notification Channel is active or not.

website/docs/r/monitor_notification_channel_slack.md

@@ -48,15 +48,10 @@ resource "sysdig_monitor_notification_channel_slack" "sample-slack" {
 
 * `channel` - (Required) Name of the Slack channel.  **NOTE**: If the channel is private this field cannot be changed after creation.
 
-* `private_channel` - (Optional, Forces new resource) If true, the Slack channel name will be visible only to the user that created this notification channel. Default: false.
+* `is_private_channel` - (Optional, Forces new resource) If true, the Slack channel name will be visible only to the user that created this notification channel. Default: false.
 
 * `private_channel_url` - (Optional, Forces new resource) The channel URL, i.e. the link that is referencing the channel (not to be confused with the webhook url). Can be set only if the channel is private.
 
-* `is_private_channel` - (Optional) Whether the Slack channel is private or not.
-
-* `private_channel_url` - (Optional) The channel URL, if channel is private.
-
-
 * `enabled` - (Optional) If false, the channel will not emit notifications. Default is true.
 
 * `notify_when_ok` - (Optional) Send a new notification when the alert condition is

website/docs/r/secure_notification_channel_slack.md

@@ -35,7 +35,7 @@ resource "sysdig_secure_notification_channel_slack" "sample-slack" {
 
 * `channel` - (Required) Name of the Slack channel. **NOTE**: If the channel is private this field cannot be changed after creation.
 
-* `private_channel` - (Optional, Forces new resource) If true, the Slack channel name will be visible only to the user that created this notification channel. Default: false.
+* `is_private_channel` - (Optional, Forces new resource) If true, the Slack channel name will be visible only to the user that created this notification channel. Default: false.
 
 * `private_channel_url` - (Optional, Forces new resource) The channel URL, i.e. the link that is referencing the channel (not to be confused with the webhook url). Can be set only if the channel is private.