refactor(monitor_alert_v2): remove deprecated trigger_after_minutes field

Author: tembleking

sysdig/resource_sysdig_monitor_alert_v2_prometheus.go

@@ -32,18 +32,10 @@ func resourceSysdigMonitorAlertV2Prometheus() *schema.Resource {
 		},
 
 		Schema: createAlertV2Schema(map[string]*schema.Schema{
-			"trigger_after_minutes": {
-				Type:         schema.TypeInt,
-				Optional:     true,
-				Computed:     true, // computed if duration_seconds is defined
-				Deprecated:   "Use duration_seconds instead",
-				ValidateFunc: validation.IntAtLeast(0),
-			},
 			"duration_seconds": {
 				Type:          schema.TypeInt,
 				Optional:      true,
 				Computed:      true, // computed if trigger_after_minutes is defined
-				ConflictsWith: []string{"trigger_after_minutes"},
 				ValidateFunc:  validation.IntAtLeast(0),
 			},
 			"query": {
@@ -171,15 +163,6 @@ func buildAlertV2PrometheusStruct(d *schema.ResourceData) *v2.AlertV2Prometheus
 		config.Duration = d.Get("duration_seconds").(int)
 	}
 
-	if d.HasChange("trigger_after_minutes") {
-		// GetOk returns true even if the value is stored only in the state and not in the user config:
-		// to avoid applying a trigger_after_minutes old value from the state even if the user removed it from the config
-		// we use HasChange that is true only if the user has changed (or created) it - and so it must be in the config
-		if attr, ok := d.GetOk("trigger_after_minutes"); ok && attr != nil {
-			config.Duration = minutesToSeconds(d.Get("trigger_after_minutes").(int))
-		}
-	}
-
 	alert := &v2.AlertV2Prometheus{
 		AlertV2Common: *alertV2Common,
 		Config:        config,
@@ -193,7 +176,6 @@ func updateAlertV2PrometheusState(d *schema.ResourceData, alert *v2.AlertV2Prome
 		return
 	}
 
-	_ = d.Set("trigger_after_minutes", secondsToMinutes(alert.Config.Duration))
 	_ = d.Set("duration_seconds", alert.Config.Duration)
 
 	_ = d.Set("query", alert.Config.Query)

website/docs/r/monitor_alert_v2_prometheus.md

@@ -40,8 +40,7 @@ These arguments are common to all alerts in Sysdig Monitor.
 
 * `name` - (Required) The name of the alert rule. It must be unique.
 * `description` - (Optional) The description of Monitor alert.
-* `duration_seconds` - (Optional, cannot be used with `trigger_after_minutes`) Specifies the amount of time, in seconds, that an alert condition must remain continuously true before the alert rule is triggered.
-* `trigger_after_minutes` - (Optional, Deprecated, cannot be used with `duration_seconds`) Specifies the amount of time, in minutes, that an alert condition must remain continuously true before the alert rule is triggered. Deprecated: use `duration_seconds` instead.
+* `duration_seconds` - (Optional) Specifies the amount of time, in seconds, that an alert condition must remain continuously true before the alert rule is triggered.
 * `group` - (Optional) Used to group alert rules in the UI. This value must be a lowercase string.
 * `severity` - (Optional) Severity of the Monitor alert. It must be `high`, `medium`, `low` or `info`. Default: `low`.
 * `enabled` - (Optional) Boolean that defines if the alert is enabled or not. Default: `true`.