fix(secure-policy): Update falco rule exceptions type to match falco expectations (#233)

* updates types for falco rule exceptions to more closely match how falco structures the exception values.

* switch back to using string so we can jsonencode the value.  update documentation to provide working example

* fix spelling in readme. fix tests.

* fix additional unit test

Author: Ben Lucas

README.md

@@ -63,7 +63,7 @@ $ make test
 If you want to execute the **acceptance tests**, you can run `make testacc`.
 - Follow [Terraform acceptance test guideliness](https://www.terraform.io/plugin/sdkv2/testing/acceptance-tests)
 - Please note that you need a token for Sysdig Monitor and another one for Sysdig Secure, and since the **acceptance tests create real infrastructure**
-you should execute them in an environment where you can remove the resorces easily.
+you should execute them in an environment where you can remove the resources easily.
 - Acceptance tests are launched in Sysdig production environment
 
 ```sh

sysdig/resource_sysdig_secure_rule_falco.go

@@ -284,10 +284,7 @@ func resourceSysdigRuleFalcoFromResourceData(d *schema.ResourceData) (secure.Rul
 			}
 
 			comps := cast.ToStringSlice(exceptionMap["comps"])
-			if len(comps) == 1 {
-				newFalcoException.Comps = comps[0]
-			}
-			if len(comps) > 1 {
+			if len(comps) >= 1 {
 				newFalcoException.Comps = comps
 			}
 
@@ -298,10 +295,7 @@ func resourceSysdigRuleFalcoFromResourceData(d *schema.ResourceData) (secure.Rul
 			}
 
 			fields := cast.ToStringSlice(exceptionMap["fields"])
-			if len(fields) == 1 {
-				newFalcoException.Fields = fields[0]
-			}
-			if len(fields) > 1 {
+			if len(fields) >= 1 {
 				newFalcoException.Fields = fields
 			}
 

sysdig/resource_sysdig_secure_rule_falco_test.go

@@ -191,12 +191,12 @@ resource "sysdig_secure_rule_falco" "falco_rule_with_exceptions" {
    name = "only_one_field"
    fields = ["ka.req.binding.subjects"]
    comps = ["in"]
-   values = jsonencode(["foo"])
+   values = jsonencode([["foo"]])
   }
   exceptions {
    name = "only_one_field_without_comps"
    fields = ["ka.req.binding.subjects"]
-   values = jsonencode(["foo"])
+   values = jsonencode([["foo"]])
   }
 }
 `, name)
@@ -213,7 +213,7 @@ resource "sysdig_secure_rule_falco" "attach_to_cluster_admin_role_exceptions" {
         name = "proc_name"
         fields = ["proc.name"]
         comps = ["in"]
-        values = jsonencode(["sh"])
+        values = jsonencode([["sh"]])
    }
 }`
 }

website/docs/r/secure_rule_falco.md

@@ -30,7 +30,7 @@ resource "sysdig_secure_rule_falco" "example" {
     name   = "proc_names"
     fields = ["proc.name"]
     comps  = ["in"]
-    values = jsonencode(["python", "python2", "python3"]) # If only one element is provided, do not specify it a list of lists.
+    values = jsonencode([[["python", "python2", "python3"]]]) # If only one element is provided, it should still needs to be specified as a list of lists.
   }
 
   exceptions {