refactor(monitor_alert_v2): remove deprecated trigger_after_minutes field

Author: tembleking

sysdig/resource_sysdig_monitor_alert_v2_downtime.go

@@ -32,18 +32,10 @@ func resourceSysdigMonitorAlertV2Downtime() *schema.Resource {
 		},
 
 		Schema: createScopedSegmentedAlertV2Schema(createAlertV2Schema(map[string]*schema.Schema{
-			"trigger_after_minutes": {
-				Type:         schema.TypeInt,
-				Optional:     true,
-				Computed:     true, // computed if range_seconds is defined
-				Deprecated:   "Use range_seconds instead",
-				ValidateFunc: validation.IntAtLeast(1),
-			},
 			"range_seconds": {
 				Type:         schema.TypeInt,
 				Optional:     true,
 				Computed:     true, // computed if trigger_after_minutes is defined
-				ExactlyOneOf: []string{"trigger_after_minutes"},
 				ValidateFunc: validation.IntAtLeast(60),
 			},
 			"threshold": {
@@ -189,15 +181,6 @@ func buildAlertV2DowntimeStruct(d *schema.ResourceData) *v2.AlertV2Downtime {
 		config.Range = d.Get("range_seconds").(int)
 	}
 
-	if d.HasChange("trigger_after_minutes") {
-		// GetOk returns true even if the value is stored only in the state and not in the user config:
-		// to avoid applying a trigger_after_minutes old value from the state even if the user removed it from the config
-		// we use HasChange that is true only if the user has changed (or created) it - and so it must be in the config
-		if attr, ok := d.GetOk("trigger_after_minutes"); ok && attr != nil {
-			config.Range = minutesToSeconds(d.Get("trigger_after_minutes").(int))
-		}
-	}
-
 	var unreportedAlertNotificationsRetentionSec *int
 	if unreportedAlertNotificationsRetentionSecInterface, ok := d.GetOk("unreported_alert_notifications_retention_seconds"); ok {
 		u := unreportedAlertNotificationsRetentionSecInterface.(int)
@@ -223,7 +206,6 @@ func updateAlertV2DowntimeState(d *schema.ResourceData, alert *v2.AlertV2Downtim
 		return err
 	}
 
-	_ = d.Set("trigger_after_minutes", secondsToMinutes(alert.Config.Range))
 	_ = d.Set("range_seconds", alert.Config.Range)
 
 	_ = d.Set("threshold", (1-alert.Config.Threshold)*100)

website/docs/r/monitor_alert_v2_downtime.md

@@ -47,8 +47,7 @@ These arguments are common to all alerts in Sysdig Monitor.
 
 * `name` - (Required) The name of the alert rule. It must be unique.
 * `description` - (Optional) The description of Monitor alert.
-* `range_seconds` - (Optional, required if `trigger_after_minutes` is not defined): The rolling time aggregation period in which the relevant metric data is evaluated.
-* `trigger_after_minutes` - (Optional, Deprecated) The rolling time aggregation period in which the relevant metric data is evaluated. Deprecated: use `range_seconds` instead.
+* `range_seconds` - (Optional): The rolling time aggregation period in which the relevant metric data is evaluated.
 * `group` - (Optional) Used to group alert rules in the UI. This value must be a lowercase string.
 * `severity` - (Optional) Severity of the Monitor alert. It must be `high`, `medium`, `low` or `info`. Default: `low`.
 * `enabled` - (Optional) Boolean that defines if the alert is enabled or not. Default: `true`.