fix: Solve Monitor alert import and vuln exception removal (#83)

* fix: Solve Monitor alert import and vuln exception removal
* chore: Remove unneeded depends
* build: Bump required Go version to 1.14

Author: tembleking

.github/workflows/ci-pull-request.yml

@@ -40,6 +40,11 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v2
 
+      - name: Set up Go
+        uses: actions/setup-go@v2
+        with:
+          go-version: ^1.14
+
       - name: Build project
         run: GOOS=${{ matrix.os }} GOARCH=${{ matrix.arch }} go build -o terraform-provider-sysdig
 

README.md

@@ -11,8 +11,8 @@ Terraform Provider for Sysdig
 Requirements
 ------------
 
--	[Terraform](https://www.terraform.io/downloads.html) 0.12.x
--	[Go](https://golang.org/doc/install) 1.13 (to build the provider plugin)
+-	[Terraform](https://www.terraform.io/downloads.html) > 0.12.x
+-	[Go](https://golang.org/doc/install) > 1.14 (to build the provider plugin)
 
 Building The Provider
 ---------------------

sysdig/internal/client/secure/vulnerability_exception.go

@@ -109,7 +109,9 @@ func (client *sysdigSecureClient) DeleteVulnerabilityException(ctx context.Conte
 	}
 	defer response.Body.Close()
 
-	if response.StatusCode != http.StatusNoContent {
+	// We will ignore the 404 error, because the exception may have been removed if the exception list has been
+	// removed as well. This should not affect the user, because removing a non existing exception has no effect.
+	if response.StatusCode != http.StatusNoContent && response.StatusCode != http.StatusNotFound {
 		return errors.New(response.Status)
 	}
 

sysdig/resource_sysdig_monitor_alert_event.go

@@ -3,6 +3,7 @@ package sysdig
 import (
 	"context"
 	"fmt"
+	"regexp"
 	"strconv"
 	"time"
 
@@ -169,15 +170,24 @@ func eventAlertFromResourceData(data *schema.ResourceData) (alert *monitor.Alert
 	return
 }
 
+// https://regex101.com/r/mmpz0D/1
+var alertConditionRegex = regexp.MustCompile(`count\(customEvent\)\s?(?P<rel>[^\w])\s?(?P<count>\d+)`)
+
 func eventAlertToResourceData(alert *monitor.Alert, data *schema.ResourceData) (err error) {
 	err = alertToResourceData(alert, data)
 	if err != nil {
 		return
 	}
 
-	var event_rel string
-	var event_count int
-	_, err = fmt.Sscanf(alert.Condition, "count(customEvent) %s %d", &event_rel, &event_count)
+	relIndex := alertConditionRegex.SubexpIndex("rel")
+	countIndex := alertConditionRegex.SubexpIndex("count")
+	matches := alertConditionRegex.FindStringSubmatch(alert.Condition)
+	if matches == nil {
+		return fmt.Errorf("alert condition %s does not match expected expression %s", alert.Condition, alertConditionRegex.String())
+	}
+
+	event_rel := matches[relIndex]
+	event_count, err := strconv.Atoi(matches[countIndex])
 	if err != nil {
 		return
 	}