Skip to content

Commit b5ce8ac

Browse files
authored
Use release namespace by default for ClusterRoleBinding (#60)
This switches the default of the cert-manager namespace to the namespace this release is going to be installed while still maintaing configurability. This makes it easier to use a custom namespace for cert-manager because designate-certmanager-webhook will most certainly just be installed in the same namespace as cert-manager.
1 parent b2cc2d2 commit b5ce8ac

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

helm/designate-certmanager-webhook/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ apiVersion: v1
22
appVersion: "0.2.12"
33
description: ACME webhook Implementation for OpenStack Designate
44
name: designate-certmanager-webhook
5-
version: "0.2.12"
5+
version: "0.2.13"

helm/designate-certmanager-webhook/templates/rbac.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ subjects:
9393
- apiGroup: ""
9494
kind: ServiceAccount
9595
name: {{ .Values.certManager.serviceAccountName }}
96-
namespace: {{ .Values.certManager.namespace }}
96+
namespace: {{ .Values.certManager.namespace | default .Release.Namespace }}
9797
- apiGroup: ""
9898
kind: ServiceAccount
9999
name: {{ include "designate-certmanager-webhook.fullname" . }}

helm/designate-certmanager-webhook/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
replicaCount: 1
22

33
certManager:
4-
namespace: cert-manager
4+
namespace: ~
55
serviceAccountName: cert-manager
66

77
image:

0 commit comments

Comments
 (0)