🐛 Fix nil pointer dereference in actionRegistering logging (#1576)

guettli · web-flow · commit 6213ecc01762 · 2025-04-03T18:53:44.000+02:00
diff --git a/pkg/services/baremetal/host/host.go b/pkg/services/baremetal/host/host.go
@@ -619,7 +619,8 @@ func (s *Service) actionRegistering(_ context.Context) actionResult {
 		if s.scope.HetznerBareMetalHost.Spec.Status.LastUpdated != nil {
 			timeSinceReboot = time.Since(s.scope.HetznerBareMetalHost.Spec.Status.LastUpdated.Time).String()
 		}
-		s.scope.Logger.Info("Could not reach rescue system. Will retry some seconds later.", "stdout", out.StdOut, "stderr", out.StdErr, "err", out.Err.Error(),
+
+		s.scope.Logger.Info("Could not reach rescue system. Will retry some seconds later.", "out", out.String(), "hostName", hostName,
 			"isSSHTimeoutError", isSSHTimeoutError, "isSSHConnectionRefusedError", isSSHConnectionRefusedError, "timeSinceReboot", timeSinceReboot)
 		return actionContinue{delay: 10 * time.Second}
 	}

Original file line number	Diff line number	Diff line change
`@@ -619,7 +619,8 @@ func (s *Service) actionRegistering(_ context.Context) actionResult {`
`619`	`619`	`if s.scope.HetznerBareMetalHost.Spec.Status.LastUpdated != nil {`
`620`	`620`	`timeSinceReboot = time.Since(s.scope.HetznerBareMetalHost.Spec.Status.LastUpdated.Time).String()`
`621`	`621`	`}`
`622`		`- s.scope.Logger.Info("Could not reach rescue system. Will retry some seconds later.", "stdout", out.StdOut, "stderr", out.StdErr, "err", out.Err.Error(),`
	`622`	`+`
	`623`	`+ s.scope.Logger.Info("Could not reach rescue system. Will retry some seconds later.", "out", out.String(), "hostName", hostName,`
`623`	`624`	`"isSSHTimeoutError", isSSHTimeoutError, "isSSHConnectionRefusedError", isSSHConnectionRefusedError, "timeSinceReboot", timeSinceReboot)`
`624`	`625`	`return actionContinue{delay: 10 * time.Second}`
`625`	`626`	`}`