Revert "🌱Add check to disallow hcloud servers without ssh key (#1413)" (#1465)

* Revert "🌱Add check to disallow hcloud servers without ssh key (#1413)"

This reverts commit 9a170a2.

We revert this, because some users want to provision clusters without ssh key.

* ... removed test, too.

Author: guettli

controllers/hcloudmachine_controller_test.go

@@ -593,25 +593,6 @@ var _ = Describe("HCloudMachineReconciler", func() {
 				}, timeout).Should(BeTrue())
 			})
 		})
-		Context("should show error when ssh key empty", func() {
-			BeforeEach(func() {
-				hetznerCluster.Spec.SSHKeys.HCloud = nil
-				hcloudMachine.Spec.SSHKeys = nil
-				hetznerCluster.Spec.HetznerSecret.Key.SSHKey = ""
-				Expect(testEnv.Create(ctx, hetznerCluster)).To(Succeed())
-				Expect(testEnv.Create(ctx, hcloudMachine)).To(Succeed())
-			})
-
-			AfterEach(func() {
-				Expect(testEnv.Cleanup(ctx, hetznerCluster, hcloudMachine)).To(Succeed())
-			})
-
-			It("should show the expected reason for server not created", func() {
-				Eventually(func() bool {
-					return isPresentAndFalseWithReason(key, hcloudMachine, infrav1.ServerCreateSucceededCondition, infrav1.SSHKeyNotFoundReason)
-				}, timeout).Should(BeTrue())
-			})
-		})
 
 		Context("with public network specs", func() {
 			var hcloudClient hcloudclient.Client

pkg/services/hcloud/server/server.go

@@ -431,17 +431,6 @@ func (s *Service) createServer(ctx context.Context) (*hcloud.Server, error) {
 		}
 	}
 
-	if len(sshKeySpecs) == 0 {
-		conditions.MarkFalse(
-			s.scope.HCloudMachine,
-			infrav1.ServerCreateSucceededCondition,
-			infrav1.SSHKeyNotFoundReason,
-			clusterv1.ConditionSeverityError,
-			"No SSH key configured for the server. Please add an SSH key",
-		)
-		return nil, errServerCreateNotPossible
-	}
-
 	// get all ssh keys that are stored in HCloud API
 	sshKeysAPI, err := s.scope.HCloudClient.ListSSHKeys(ctx, hcloud.SSHKeyListOpts{})
 	if err != nil {