inlined creation of ProviderID, to reduce complexity.

Author: guettli

pkg/services/baremetal/baremetal/baremetal.go

@@ -55,8 +55,6 @@ import (
 // TODO: Implement logic for removal of unpaid servers.
 
 const (
-	providerIDPrefix = "hrobot://"
-
 	// requeueAfter gives the duration of time until the next reconciliation should be performed.
 	requeueAfter = time.Second * 30
 
@@ -684,7 +682,7 @@ func (s *Service) setProviderID(ctx context.Context) error {
 	}
 
 	// set providerID
-	providerID := providerIDFromServerID(host.Spec.ServerID)
+	providerID := fmt.Sprintf("hrobot://%d", host.Spec.ServerID)
 	s.scope.BareMetalMachine.Spec.ProviderID = &providerID
 	s.scope.BareMetalMachine.Status.Phase = clusterv1.MachinePhaseRunning
 
@@ -899,12 +897,6 @@ func checkForRequeueError(err error, errMessage string) (res reconcile.Result, r
 	return reconcile.Result{}, fmt.Errorf("%s: %w", errMessage, err)
 }
 
-// providerIDFromServerID returns the ProviderID. See HetznerBareMetalMachineSpec.ProviderID for
-// docs.
-func providerIDFromServerID(serverID int) string {
-	return fmt.Sprintf("%s%d", providerIDPrefix, serverID)
-}
-
 func analyzePatchError(err error, ignoreNotFound bool) error {
 	if apierrors.IsConflict(err) {
 		return &scope.RequeueAfterError{}

pkg/services/baremetal/baremetal/baremetal_test.go

@@ -702,10 +702,6 @@ var _ = Describe("Test ensureClusterLabel", func() {
 	)
 })
 
-var _ = Describe("Test providerIDFromServerID", func() {
-	Expect(providerIDFromServerID(42)).To(Equal("hrobot://42"))
-})
-
 var _ = Describe("Test hostKey", func() {
 	host := &infrav1.HetznerBareMetalHost{}
 	host.Namespace = "namespace"