Skip to content

Commit b6a2dec

Browse files
🌱 Update hetznercluster_types.go (#1179)
Update API descriptions for hetznercluster object Update api/v1beta1/hetznercluster_types.go Co-authored-by: janiskemper <[email protected]>
1 parent befd9c8 commit b6a2dec

File tree

3 files changed

+17
-18
lines changed

3 files changed

+17
-18
lines changed

api/v1beta1/hetznercluster_types.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,18 +27,18 @@ const (
2727
// apiserver.
2828
ClusterFinalizer = "hetznercluster.infrastructure.cluster.x-k8s.io"
2929
// AllowEmptyControlPlaneAddressAnnotation allows HetznerCluster Webhook
30-
// to skip some validation steps for external managed controle planes.
30+
// to skip some validation steps for externally managed control planes.
3131
AllowEmptyControlPlaneAddressAnnotation = "capi.syself.com/allow-empty-control-plane-address"
3232
)
3333

3434
// HetznerClusterSpec defines the desired state of HetznerCluster.
3535
type HetznerClusterSpec struct {
36-
// HCloudNetworkSpec defines the Network for Hetzner Cloud. If left empty no private Network is configured.
36+
// HCloudNetwork defines details about the private Network for Hetzner Cloud. If left empty, no private Network is configured.
3737
// +optional
3838
HCloudNetwork HCloudNetworkSpec `json:"hcloudNetwork"`
3939

4040
// ControlPlaneRegion consists of a list of HCloud Regions (fsn, nbg, hel). Because HCloud Networks
41-
// have a very low latency we could assume in some use-cases that a region is behaving like a zone
41+
// have a very low latency we could assume in some use cases that a region is behaving like a zone.
4242
// https://kubernetes.io/docs/reference/labels-annotations-taints/#topologykubernetesiozone
4343
ControlPlaneRegions []Region `json:"controlPlaneRegions"`
4444

@@ -48,7 +48,7 @@ type HetznerClusterSpec struct {
4848
// +optional
4949
ControlPlaneEndpoint *clusterv1.APIEndpoint `json:"controlPlaneEndpoint,omitempty"`
5050

51-
// ControlPlaneLoadBalancer is optional configuration for customizing control plane behavior. Naming convention is from upstream cluster-api project.
51+
// ControlPlaneLoadBalancer is an optional configuration for customizing control plane behavior.
5252
ControlPlaneLoadBalancer LoadBalancerSpec `json:"controlPlaneLoadBalancer,omitempty"`
5353

5454
// +optional

config/crd/bases/infrastructure.cluster.x-k8s.io_hetznerclusters.yaml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,8 @@ spec:
8282
- port
8383
type: object
8484
controlPlaneLoadBalancer:
85-
description: ControlPlaneLoadBalancer is optional configuration for
86-
customizing control plane behavior. Naming convention is from upstream
87-
cluster-api project.
85+
description: ControlPlaneLoadBalancer is an optional configuration
86+
for customizing control plane behavior.
8887
properties:
8988
algorithm:
9089
allOf:
@@ -160,8 +159,8 @@ spec:
160159
controlPlaneRegions:
161160
description: ControlPlaneRegion consists of a list of HCloud Regions
162161
(fsn, nbg, hel). Because HCloud Networks have a very low latency
163-
we could assume in some use-cases that a region is behaving like
164-
a zone https://kubernetes.io/docs/reference/labels-annotations-taints/#topologykubernetesiozone
162+
we could assume in some use cases that a region is behaving like
163+
a zone. https://kubernetes.io/docs/reference/labels-annotations-taints/#topologykubernetesiozone
165164
items:
166165
description: Region is a Hetzner Location
167166
enum:
@@ -173,8 +172,8 @@ spec:
173172
type: string
174173
type: array
175174
hcloudNetwork:
176-
description: HCloudNetworkSpec defines the Network for Hetzner Cloud.
177-
If left empty no private Network is configured.
175+
description: HCloudNetwork defines details about the private Network
176+
for Hetzner Cloud. If left empty, no private Network is configured.
178177
properties:
179178
cidrBlock:
180179
default: 10.0.0.0/16

config/crd/bases/infrastructure.cluster.x-k8s.io_hetznerclustertemplates.yaml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,8 @@ spec:
103103
- port
104104
type: object
105105
controlPlaneLoadBalancer:
106-
description: ControlPlaneLoadBalancer is optional configuration
107-
for customizing control plane behavior. Naming convention
108-
is from upstream cluster-api project.
106+
description: ControlPlaneLoadBalancer is an optional configuration
107+
for customizing control plane behavior.
109108
properties:
110109
algorithm:
111110
allOf:
@@ -182,8 +181,8 @@ spec:
182181
controlPlaneRegions:
183182
description: ControlPlaneRegion consists of a list of HCloud
184183
Regions (fsn, nbg, hel). Because HCloud Networks have a
185-
very low latency we could assume in some use-cases that
186-
a region is behaving like a zone https://kubernetes.io/docs/reference/labels-annotations-taints/#topologykubernetesiozone
184+
very low latency we could assume in some use cases that
185+
a region is behaving like a zone. https://kubernetes.io/docs/reference/labels-annotations-taints/#topologykubernetesiozone
187186
items:
188187
description: Region is a Hetzner Location
189188
enum:
@@ -195,8 +194,9 @@ spec:
195194
type: string
196195
type: array
197196
hcloudNetwork:
198-
description: HCloudNetworkSpec defines the Network for Hetzner
199-
Cloud. If left empty no private Network is configured.
197+
description: HCloudNetwork defines details about the private
198+
Network for Hetzner Cloud. If left empty, no private Network
199+
is configured.
200200
properties:
201201
cidrBlock:
202202
default: 10.0.0.0/16

0 commit comments

Comments
 (0)