🌱 Make concurrent execution of make test-unit possible. (#1678)

Author: guettli

test/helpers/envtest.go

@@ -47,6 +47,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/cache"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/envtest"
+	metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
 	"sigs.k8s.io/controller-runtime/pkg/webhook"
 
 	infrav1 "github.com/syself/cluster-api-provider-hetzner/api/v1beta1"
@@ -145,6 +146,10 @@ func NewTestEnvironment() *TestEnvironment {
 				Host:    "localhost",
 			},
 		),
+		Metrics: metricsserver.Options{
+			// Disable MetricsServer, so that two tests processes can run concurrently
+			BindAddress: "0",
+		},
 	})
 	if err != nil {
 		klog.Fatalf("unable to create manager: %s", err)

test/helpers/webhook.go

@@ -95,8 +95,14 @@ func initializeWebhookInEnvironment() {
 		klog.Fatalf("Failed to append core controller webhook config: %v", err)
 	}
 
+	// Two tests processes should be able ro run concurrently. Each needs an own port:
+	port, err := getFreePort()
+	if err != nil {
+		klog.Fatalf("Failed to get a free port for webhook: %v", err)
+	}
+
 	env.WebhookInstallOptions = envtest.WebhookInstallOptions{
-		LocalServingPort:   9443,
+		LocalServingPort:   port,
 		LocalServingHost:   "localhost",
 		MaxTime:            20 * time.Second,
 		PollInterval:       time.Second,
@@ -126,3 +132,13 @@ func (t *TestEnvironment) WaitForWebhooks() {
 		return
 	}
 }
+
+func getFreePort() (port int, err error) {
+	ln, err := net.Listen("tcp", "[::]:0")
+	if err != nil {
+		return 0, err
+	}
+	port = ln.Addr().(*net.TCPAddr).Port
+	err = ln.Close()
+	return
+}