Skip to content

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Jan 6, 2025

No description provided.

@ivmarkov
Copy link
Collaborator

ivmarkov commented Jan 7, 2025

Nit: If you could also update the Changelogs and put in #[Unreleased] a section that describes why we bump the minor version number (changelogs are not updated automatically; yet)? Sorry for asking, and I can also do that post-merge of the PR myself if you don't feel like doing it - you already did more than enough!

@bugadani bugadani marked this pull request as ready for review January 7, 2025 17:22
@bugadani bugadani marked this pull request as draft January 7, 2025 17:22
@bugadani
Copy link
Contributor Author

bugadani commented Jan 7, 2025

Oh whoops this should stay draft while there is a git dependency there.

@ivmarkov ivmarkov marked this pull request as ready for review January 15, 2025 19:22
@ivmarkov ivmarkov merged commit 4bad2d4 into sysgrok:master Jan 15, 2025
2 checks passed
@ivmarkov
Copy link
Collaborator

@bugadani Thanks!

@bugadani bugadani deleted the embassy-time branch January 15, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants