Improve log command feedback

EricccTaiwan · charliechiou · EricccTaiwan · commit 0be3e8333f3a · 2025-03-11T03:17:00.000+08:00
Enhance the "log" command by providing clearer feedback to users.
Now, if no log file is specified, the message explicitly suggests
using "log &lt;file&gt;" for better clarity. Additionally, a message is
printed when logging is enabled, improving user awareness.

Co-authored-by: charliechiou &lt;charlie910417@gmail.com&gt;
Change-Id: I355f3f13bd959ddecc2893d202642accc565fb8a
diff --git a/console.c b/console.c
@@ -370,14 +370,15 @@ static bool do_source(int argc, char *argv[])
 static bool do_log(int argc, char *argv[])
 {
     if (argc < 2) {
-        report(1, "No log file given");
+        report(1, "No log file given. Use 'log <file>'.");
         return false;
     }
 
     bool result = set_logfile(argv[1]);
     if (!result)
         report(1, "Couldn't open log file '%s'", argv[1]);
 
+    printf("Logging enabled: %s\n", argv[1]);
     return result;
 }
 
diff --git a/eric.txt b/eric.txt
@@ -0,0 +1,2 @@
+No log file given. Use 'log <file>'.
+Freeing queue

Original file line number	Diff line number	Diff line change
`@@ -370,14 +370,15 @@ static bool do_source(int argc, char *argv[])`
`370`	`370`	`static bool do_log(int argc, char *argv[])`
`371`	`371`	`{`
`372`	`372`	`if (argc < 2) {`
`373`		`- report(1, "No log file given");`
	`373`	`+ report(1, "No log file given. Use 'log <file>'.");`
`374`	`374`	`return false;`
`375`	`375`	`}`
`376`	`376`
`377`	`377`	`bool result = set_logfile(argv[1]);`
`378`	`378`	`if (!result)`
`379`	`379`	`report(1, "Couldn't open log file '%s'", argv[1]);`
`380`	`380`
	`381`	`+ printf("Logging enabled: %s\n", argv[1]);`
`381`	`382`	`return result;`
`382`	`383`	`}`
`383`	`384`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+No log file given. Use 'log <file>'.`
	`2`	`+Freeing queue`