@@ -345,44 +345,43 @@ static void _twin_composite_simple(twin_pixmap_t *dst,
345345 if (src -> source_kind == TWIN_PIXMAP ) {
346346 src_x += src -> u .pixmap -> origin_x ;
347347 src_y += src -> u .pixmap -> origin_y ;
348- } else
348+ } else {
349349 s .c = src -> u .argb ;
350+ }
350351
351352 sdx = src_x - dst_x ;
352353 sdy = src_y - dst_y ;
353354
354355 if (msk ) {
355- twin_src_msk_op op ;
356356 twin_source_u m ;
357357 twin_coord_t mdx , mdy ;
358358
359359 if (msk -> source_kind == TWIN_PIXMAP ) {
360360 msk_x += msk -> u .pixmap -> origin_x ;
361361 msk_y += msk -> u .pixmap -> origin_y ;
362- } else
362+ } else {
363363 m .c = msk -> u .argb ;
364+ }
364365
365366 mdx = msk_x - dst_x ;
366367 mdy = msk_y - dst_y ;
367368
368- op = comp3 [operator ][operand_index (src )][operand_index (msk )][dst -> format ];
369- for (iy = top ; iy < bottom ; iy ++ ) {
370- if (src -> source_kind == TWIN_PIXMAP )
371- s .p = twin_pixmap_pointer (src -> u .pixmap , left + sdx , iy + sdy );
372- if (msk -> source_kind == TWIN_PIXMAP )
373- m .p = twin_pixmap_pointer (msk -> u .pixmap , left + mdx , iy + mdy );
374- (* op )(twin_pixmap_pointer (dst , left , iy ), s , m , right - left );
375- }
369+ twin_src_msk_op op = comp3 [operator ][operand_index (src )][operand_index (msk )][dst -> format ];
370+ for (iy = top ; iy < bottom ; iy ++ ) {
371+ if (src -> source_kind == TWIN_PIXMAP )
372+ s .p = twin_pixmap_pointer (src -> u .pixmap , left + sdx , iy + sdy );
373+ if (msk -> source_kind == TWIN_PIXMAP )
374+ m .p = twin_pixmap_pointer (msk -> u .pixmap , left + mdx , iy + mdy );
375+ (* op )(twin_pixmap_pointer (dst , left , iy ), s , m , right - left );
376+ }
376377 } else {
377- twin_src_op op ;
378-
379- op = comp2 [operator ][operand_index (src )][dst -> format ];
378+ twin_src_op op = comp2 [operator ][operand_index (src )][dst -> format ];
380379
381- for (iy = top ; iy < bottom ; iy ++ ) {
382- if (src -> source_kind == TWIN_PIXMAP )
383- s .p = twin_pixmap_pointer (src -> u .pixmap , left + sdx , iy + sdy );
384- (* op )(twin_pixmap_pointer (dst , left , iy ), s , right - left );
385- }
380+ for (iy = top ; iy < bottom ; iy ++ ) {
381+ if (src -> source_kind == TWIN_PIXMAP )
382+ s .p = twin_pixmap_pointer (src -> u .pixmap , left + sdx , iy + sdy );
383+ (* op )(twin_pixmap_pointer (dst , left , iy ), s , right - left );
384+ }
386385 }
387386 twin_pixmap_damage (dst , left , top , right , bottom );
388387}
@@ -400,14 +399,14 @@ static twin_xform_t *twin_pixmap_init_xform(twin_pixmap_t *pixmap,
400399 twin_coord_t src_x ,
401400 twin_coord_t src_y )
402401{
403- twin_xform_t * xform ;
404402 twin_format_t fmt = pixmap -> format ;
405403
406404 if (fmt == TWIN_RGB16 )
407405 fmt = TWIN_ARGB32 ;
408406
409- xform = calloc (1 , sizeof (twin_xform_t ) + width * twin_bytes_per_pixel (fmt ));
410- if (xform == NULL )
407+ twin_xform_t * xform =
408+ calloc (1 , sizeof (twin_xform_t ) + width * twin_bytes_per_pixel (fmt ));
409+ if (!xform )
411410 return NULL ;
412411
413412 xform -> span .v = (twin_argb32_t * ) (char * ) (xform + 1 );
@@ -578,7 +577,6 @@ static void _twin_composite_xform(twin_pixmap_t *dst,
578577 twin_coord_t width ,
579578 twin_coord_t height )
580579{
581- twin_coord_t iy ;
582580 twin_coord_t left , top , right , bottom ;
583581 twin_xform_t * sxform = NULL , * mxform = NULL ;
584582 twin_source_u s ;
@@ -611,46 +609,45 @@ static void _twin_composite_xform(twin_pixmap_t *dst,
611609 src_y += src -> u .pixmap -> origin_y ;
612610 sxform =
613611 twin_pixmap_init_xform (src -> u .pixmap , left , width , src_x , src_y );
614- if (sxform == NULL )
612+ if (! sxform )
615613 return ;
616614 s .p = sxform -> span ;
617- } else
615+ } else {
618616 s .c = src -> u .argb ;
617+ }
619618
620619 if (msk ) {
621- twin_src_msk_op op ;
622620 twin_source_u m ;
623621
624622 if (msk -> source_kind == TWIN_PIXMAP ) {
625623 msk_x += msk -> u .pixmap -> origin_x ;
626624 msk_y += msk -> u .pixmap -> origin_y ;
627625 mxform = twin_pixmap_init_xform (msk -> u .pixmap , left , width , msk_x ,
628626 msk_y );
629- if (mxform == NULL )
627+ if (! mxform )
630628 return ;
631629 m .p = mxform -> span ;
632- } else
630+ } else {
633631 m .c = msk -> u .argb ;
632+ }
634633
635- op = comp3 [operator ][operand_xindex (src )][operand_xindex (msk )]
634+ twin_src_msk_op op = comp3 [operator ][operand_xindex (src )][operand_xindex (msk )]
636635 [dst -> format ];
637- for (iy = top ; iy < bottom ; iy ++ ) {
638- if (src -> source_kind == TWIN_PIXMAP )
639- twin_pixmap_read_xform (sxform , iy - top );
640- if (msk -> source_kind == TWIN_PIXMAP )
641- twin_pixmap_read_xform (mxform , iy - top );
642- (* op )(twin_pixmap_pointer (dst , left , iy ), s , m , right - left );
643- }
636+ for (twin_coord_t iy = top ; iy < bottom ; iy ++ ) {
637+ if (src -> source_kind == TWIN_PIXMAP )
638+ twin_pixmap_read_xform (sxform , iy - top );
639+ if (msk -> source_kind == TWIN_PIXMAP )
640+ twin_pixmap_read_xform (mxform , iy - top );
641+ (* op )(twin_pixmap_pointer (dst , left , iy ), s , m , right - left );
642+ }
644643 } else {
645- twin_src_op op ;
646-
647- op = comp2 [operator ][operand_xindex (src )][dst -> format ];
644+ twin_src_op op = comp2 [operator ][operand_xindex (src )][dst -> format ];
648645
649- for (iy = top ; iy < bottom ; iy ++ ) {
650- if (src -> source_kind == TWIN_PIXMAP )
651- twin_pixmap_read_xform (sxform , iy - top );
652- (* op )(twin_pixmap_pointer (dst , left , iy ), s , right - left );
653- }
646+ for (twin_coord_t iy = top ; iy < bottom ; iy ++ ) {
647+ if (src -> source_kind == TWIN_PIXMAP )
648+ twin_pixmap_read_xform (sxform , iy - top );
649+ (* op )(twin_pixmap_pointer (dst , left , iy ), s , right - left );
650+ }
654651 }
655652 twin_pixmap_damage (dst , left , top , right , bottom );
656653 twin_pixmap_free_xform (sxform );
@@ -673,12 +670,13 @@ void twin_composite(twin_pixmap_t *dst,
673670 if ((src -> source_kind == TWIN_PIXMAP &&
674671 !twin_matrix_is_identity (& src -> u .pixmap -> transform )) ||
675672 (msk && (msk -> source_kind == TWIN_PIXMAP &&
676- !twin_matrix_is_identity (& msk -> u .pixmap -> transform ))))
673+ !twin_matrix_is_identity (& msk -> u .pixmap -> transform )))) {
677674 _twin_composite_xform (dst , dst_x , dst_y , src , src_x , src_y , msk , msk_x ,
678675 msk_y , operator , width , height );
679- else
676+ } else {
680677 _twin_composite_simple (dst , dst_x , dst_y , src , src_x , src_y , msk , msk_x ,
681678 msk_y , operator , width , height );
679+ }
682680}
683681
684682/*
@@ -708,10 +706,6 @@ void twin_fill(twin_pixmap_t *dst,
708706 twin_coord_t right ,
709707 twin_coord_t bottom )
710708{
711- twin_src_op op ;
712- twin_source_u src ;
713- twin_coord_t iy ;
714-
715709 /* offset */
716710 left += dst -> origin_x ;
717711 top += dst -> origin_y ;
@@ -729,9 +723,10 @@ void twin_fill(twin_pixmap_t *dst,
729723 bottom = dst -> clip .bottom ;
730724 if (left >= right || top >= bottom )
731725 return ;
732- src .c = pixel ;
733- op = fill [operator ][dst -> format ];
734- for (iy = top ; iy < bottom ; iy ++ )
726+
727+ twin_source_u src = {.c = pixel };
728+ twin_src_op op = fill [operator ][dst -> format ];
729+ for (twin_coord_t iy = top ; iy < bottom ; iy ++ )
735730 (* op )(twin_pixmap_pointer (dst , left , iy ), src , right - left );
736731 twin_pixmap_damage (dst , left , top , right , bottom );
737732}
0 commit comments