calc: Set maximum digit length to 9 (#35)

Bennctu · web-flow · commit fd3e451d2f60 · 2024-08-22T18:51:37.000+08:00
The type of calc->stack[0] is an integer, and the maximum value for an int is 2147483647. To ensure safety, when the length reaches 9 digits, pressing the digit button will not increase the number of digits. Close #25
diff --git a/apps/calc.c b/apps/calc.c
@@ -119,6 +119,12 @@ static void _apps_calc_digit(apps_calc_t *calc, int digit)
         calc->stack[0] = 0;
         calc->pending_delete = false;
     }
+
+    /* When the length reaches 9 digits, pressing the digit button will not
+     * increase the number of digits. */
+    if (calc->stack[0] > 99999999)
+        return;
+
     calc->stack[0] = calc->stack[0] * 10 + digit;
     _apps_calc_update_value(calc);
 }

Original file line number	Diff line number	Diff line change
`@@ -119,6 +119,12 @@ static void _apps_calc_digit(apps_calc_t *calc, int digit)`
`119`	`119`	`calc->stack[0] = 0;`
`120`	`120`	`calc->pending_delete = false;`
`121`	`121`	`}`
	`122`	`+`
	`123`	`+ /* When the length reaches 9 digits, pressing the digit button will not`
	`124`	`+ * increase the number of digits. */`
	`125`	`+ if (calc->stack[0] > 99999999)`
	`126`	`+ return;`
	`127`	`+`
`122`	`128`	`calc->stack[0] = calc->stack[0] * 10 + digit;`
`123`	`129`	`_apps_calc_update_value(calc);`
`124`	`130`	`}`