Fix Clang error when disabling BLOCK_CHAINING

eleanorLYJ · eleanorLYJ · commit 01f232833692 · 2025-01-16T11:41:01.000+08:00
When using 'make ENABLE_MBLOCK_CHAINING=0 CC=clang', the following
errors are observed:
src/emulate.c:555:19: error: unused function 'insn_is_unconditional_branch' [-Werror,-Wunused-function]
  555 | FORCE_INLINE bool insn_is_unconditional_branch(uint8_t opcode)
      |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/emulate.c:582:19: error: unused function 'insn_is_direct_branch' [-Werror,-Wunused-function]
  582 | FORCE_INLINE bool insn_is_direct_branch(uint8_t opcode)
      |                   ^~~~~~~~~~~~~~~~~~~~~

Fix this by guarding the 'insn_is_unconditional_branch' and
'insn_is_direct_branch' function definition with
RV32_HAS(BLOCK_CHAINING) macro. This ensures the functions are only
defined when the BLOCK_CHAINING is enabled.
diff --git a/src/emulate.c b/src/emulate.c
@@ -550,6 +550,7 @@ FORCE_INLINE bool insn_is_translatable(uint8_t opcode)
 }
 #endif
 
+#if RV32_HAS(BLOCK_CHAINING)
 FORCE_INLINE bool insn_is_unconditional_branch(uint8_t opcode)
 {
     switch (opcode) {
@@ -590,6 +591,7 @@ FORCE_INLINE bool insn_is_direct_branch(uint8_t opcode)
         return false;
     }
 }
+#endif
 
 FORCE_INLINE bool insn_is_indirect_branch(uint8_t opcode)
 {

Original file line number	Diff line number	Diff line change
`@@ -550,6 +550,7 @@ FORCE_INLINE bool insn_is_translatable(uint8_t opcode)`
`550`	`550`	`}`
`551`	`551`	`#endif`
`552`	`552`
	`553`	`+#if RV32_HAS(BLOCK_CHAINING)`
`553`	`554`	`FORCE_INLINE bool insn_is_unconditional_branch(uint8_t opcode)`
`554`	`555`	`{`
`555`	`556`	`switch (opcode) {`
`@@ -590,6 +591,7 @@ FORCE_INLINE bool insn_is_direct_branch(uint8_t opcode)`
`590`	`591`	`return false;`
`591`	`592`	`}`
`592`	`593`	`}`
	`594`	`+#endif`
`593`	`595`
`594`	`596`	`FORCE_INLINE bool insn_is_indirect_branch(uint8_t opcode)`
`595`	`597`	`{`