Fix Clang error when disabling BLOCK_CHAINING

eleanorLYJ · eleanorLYJ · commit 312c83f35d60 · 2025-01-07T00:13:33.000+08:00
When using 'make ENABLE_MBLOCK_CHAINING=0 CC=clang', the following
errors are observed:
src/emulate.c:555:19: error: unused function 'insn_is_unconditional_branch' [-Werror,-Wunused-function]
  555 | FORCE_INLINE bool insn_is_unconditional_branch(uint8_t opcode)
      |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/emulate.c:582:19: error: unused function 'insn_is_direct_branch' [-Werror,-Wunused-function]
  582 | FORCE_INLINE bool insn_is_direct_branch(uint8_t opcode)
      |                   ^~~~~~~~~~~~~~~~~~~~~

Fix this by guarding the 'insn_is_unconditional_branch' and
'insn_is_direct_branch' function definition with
RV32_HAS(BLOCK_CHAINING) macro. This ensures the functions are only
defined when the BLOCK_CHAINING is enabled.
diff --git a/src/emulate.c b/src/emulate.c
@@ -552,6 +552,7 @@ FORCE_INLINE bool insn_is_translatable(uint8_t opcode)
 }
 #endif
 
+#if RV32_HAS(BLOCK_CHAINING)
 FORCE_INLINE bool insn_is_unconditional_branch(uint8_t opcode)
 {
     switch (opcode) {
@@ -592,6 +593,7 @@ FORCE_INLINE bool insn_is_direct_branch(uint8_t opcode)
         return false;
     }
 }
+#endif
 
 FORCE_INLINE bool insn_is_indirect_branch(uint8_t opcode)
 {

Original file line number	Diff line number	Diff line change
`@@ -552,6 +552,7 @@ FORCE_INLINE bool insn_is_translatable(uint8_t opcode)`
`552`	`552`	`}`
`553`	`553`	`#endif`
`554`	`554`
	`555`	`+#if RV32_HAS(BLOCK_CHAINING)`
`555`	`556`	`FORCE_INLINE bool insn_is_unconditional_branch(uint8_t opcode)`
`556`	`557`	`{`
`557`	`558`	`switch (opcode) {`
`@@ -592,6 +593,7 @@ FORCE_INLINE bool insn_is_direct_branch(uint8_t opcode)`
`592`	`593`	`return false;`
`593`	`594`	`}`
`594`	`595`	`}`
	`596`	`+#endif`
`595`	`597`
`596`	`598`	`FORCE_INLINE bool insn_is_indirect_branch(uint8_t opcode)`
`597`	`599`	`{`