Filter out non block devices from /dev/

Author: ChinYikMing

src/devices/virtio-blk.c

@@ -428,6 +428,12 @@ uint32_t *virtio_blk_init(virtio_blk_state_t *vblk,
         goto fail;
     }
 
+    struct stat st;
+    if (fstat(disk_fd, &st) == -1) {
+        rv_log_error("fstat failed");
+        goto disk_size_fail;
+    }
+
     const char *disk_file_dirname = dirname(disk_file);
     if (!disk_file_dirname) {
         rv_log_error("Fail dirname disk_file: %s", disk_file);
@@ -436,6 +442,10 @@ uint32_t *virtio_blk_init(virtio_blk_state_t *vblk,
     /* Get the disk size */
     uint64_t disk_size;
     if (!strcmp(disk_file_dirname, "/dev")) { /* from /dev/, leverage ioctl */
+        if ((st.st_mode & S_IFMT) != S_IFBLK) {
+            rv_log_error("%s is not block device", disk_file);
+            goto fail;
+        }
 #if !defined(__EMSCRIPTEN__)
 #if defined(__APPLE__)
         uint32_t block_size;
@@ -456,12 +466,7 @@ uint32_t *virtio_blk_init(virtio_blk_state_t *vblk,
         }
 #endif
 #endif       /* !defined(__EMSCRIPTEN__) */
-    } else { /* other path, stat it as normal file */
-        struct stat st;
-        if (fstat(disk_fd, &st) == -1) {
-            rv_log_error("fstat failed");
-            goto disk_size_fail;
-        }
+    } else { /* other path, get the size of block device via stat buffer */
         disk_size = st.st_size;
     }
     VBLK_PRIV(vblk)->disk_size = disk_size;