Clear block only needs when retranslate

ChinYikMing · ChinYikMing · commit 6466aa1e8edb · 2024-11-02T20:49:26.000+08:00
diff --git a/src/emulate.c b/src/emulate.c
@@ -567,7 +567,6 @@ FORCE_INLINE bool insn_is_unconditional_branch(uint8_t opcode)
 static void block_translate(riscv_t *rv, block_t *block)
 {
 retranslate:
-    memset(block, 0, sizeof(block_t));
     block->pc_start = block->pc_end = rv->PC;
 
     rv_insn_t *prev_ir = NULL;
@@ -584,6 +583,7 @@ static void block_translate(riscv_t *rv, block_t *block)
 
 #if RV32_HAS(SYSTEM)
         if (!insn && need_retranslate) {
+            memset(block, 0, sizeof(block_t));
             need_retranslate = false;
             goto retranslate;
         }

Original file line number	Diff line number	Diff line change
`@@ -567,7 +567,6 @@ FORCE_INLINE bool insn_is_unconditional_branch(uint8_t opcode)`
`567`	`567`	`static void block_translate(riscv_t rv, block_t block)`
`568`	`568`	`{`
`569`	`569`	`retranslate:`
`570`		`- memset(block, 0, sizeof(block_t));`
`571`	`570`	`block->pc_start = block->pc_end = rv->PC;`
`572`	`571`
`573`	`572`	`rv_insn_t *prev_ir = NULL;`
`@@ -584,6 +583,7 @@ static void block_translate(riscv_t rv, block_t block)`
`584`	`583`
`585`	`584`	`#if RV32_HAS(SYSTEM)`
`586`	`585`	`if (!insn && need_retranslate) {`
	`586`	`+ memset(block, 0, sizeof(block_t));`
`587`	`587`	`need_retranslate = false;`
`588`	`588`	`goto retranslate;`
`589`	`589`	`}`