Skip to content

Commit 69e9793

Browse files
committed
Remove ENABLE_UBSAN
1 parent 92493cd commit 69e9793

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

.github/workflows/main.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,12 +78,12 @@ jobs:
7878
make ENABLE_JIT=1 clean clean && make ENABLE_JIT=1 ENABLE_UBSAN=1 check -j$(nproc)
7979
- name: valgrind check (without JIT)
8080
run: |
81-
make clean && make ENABLE_SDL=0 ENABLE_JIT=0 ENABLE_VALGRIND=1
81+
make clean && make ENABLE_SDL=0 ENABLE_JIT=0 ENABLE_UBSAN=1
8282
valgrind --leak-check=full --show-leak-kinds=all --error-exitcode=1 ./build/rv32emu ./build/hello.elf
8383
valgrind --leak-check=full --show-leak-kinds=all --error-exitcode=1 ./build/rv32emu ./build/aes.elf
8484
- name: valgrind check (with JIT)
8585
run: |
86-
make clean && make ENABLE_SDL=0 ENABLE_JIT=1 ENABLE_VALGRIND=1
86+
make clean && make ENABLE_SDL=0 ENABLE_JIT=1 ENABLE_UBSAN=1
8787
valgrind --leak-check=full --show-leak-kinds=all --error-exitcode=1 ./build/rv32emu ./build/hello.elf
8888
valgrind --leak-check=full --show-leak-kinds=all --error-exitcode=1 ./build/rv32emu ./build/aes.elf
8989

Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ CFLAGS = -std=gnu99 -O2 -Wall -Wextra
1111
CFLAGS += -Wno-unused-label
1212
CFLAGS += -include src/common.h
1313

14-
ENABLE_VALGRIND ?= 0
1514
ifeq ("$(ENABLE_UBSAN)", "1")
1615
# according to gcc's man page: "If you use multiple -O options, with or without level numbers, the last such option is the one that is effective."
1716
# In order to use Valgrind, we need to compile with -g

0 commit comments

Comments
 (0)