Skip to content

Commit ce27e80

Browse files
committed
Disable remote GDB support by default
The continuous benchmark has been integrated along with recent improvements for general performance. It's worth noting that remote GDB support can have a negative impact on instruction execution. To ensure that the continuous benchmark accurately reflects the performance metrics, it is advisable to exclude GDB support at the moment.
1 parent 4bc8456 commit ce27e80

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

.github/workflows/main.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,13 @@ jobs:
2424
make distclean ENABLE_ARC=1 tests
2525
- name: diverse configurations
2626
run: |
27+
make distclean ENABLE_EXT_A=0 check
2728
make distclean ENABLE_EXT_C=0 check
2829
make distclean ENABLE_EXT_F=0 check
29-
make distclean ENABLE_GDBSTUB=0 check
3030
make distclean ENABLE_SDL=0 check
3131
- name: gdbstub test
3232
run: |
33-
make gdbstub-test
33+
make distclean ENABLE_GDBSTUB=1 gdbstub-test
3434
3535
coding-style:
3636
runs-on: ubuntu-22.04

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ LDFLAGS += $(shell sdl2-config --libs) -pthread
6969
LDFLAGS += $(shell pkg-config --libs SDL2_mixer)
7070
endif
7171

72-
ENABLE_GDBSTUB ?= 1
72+
ENABLE_GDBSTUB ?= 0
7373
$(call set-feature, GDBSTUB)
7474
ifeq ($(call has, GDBSTUB), 1)
7575
GDBSTUB_OUT = $(abspath $(OUT)/mini-gdbstub)

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,8 @@ Detail in riscv-arch-test:
148148

149149
`rv32emu` is permitted to operate as gdbstub in an experimental manner since it supports
150150
a limited number of [GDB Remote Serial Protocol](https://sourceware.org/gdb/onlinedocs/gdb/Remote-Protocol.html) (GDBRSP).
151-
You must first build the emulator and set `ENABLE_GDBSTUB` to `1` in the `Makefile` in order
152-
to activate this feature. After that, you might execute it using the command below.
151+
To enable this feature, you need to build the emulator and set `ENABLE_GDBSTUB=1` when running the `make` command.
152+
After that, you might execute it using the command below.
153153
```shell
154154
$ build/rv32emu -g <binary>
155155
```

src/feature.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444

4545
/* GDB remote debugging */
4646
#ifndef RV32_FEATURE_GDBSTUB
47-
#define RV32_FEATURE_GDBSTUB 1
47+
#define RV32_FEATURE_GDBSTUB 0
4848
#endif
4949

5050
/* Import adaptive replacement cache to manage block */

0 commit comments

Comments
 (0)