Fix regressions caused by ASSERT output capture

This commit fixes the CI timeout issue where netdev tests would hang for
10 minutes and fail. The root cause was the ASSERT function capturing
command output, which broke expect's TTY interaction.

The original implementation executed commands directly without capture,
which is essential for interactive commands like expect. Capturing
output broke the TTY connection that expect requires.

Author: jserv

.ci/autorun.sh

@@ -4,6 +4,9 @@
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 source "${SCRIPT_DIR}/common.sh"
 
+# Clean up any existing semu processes before starting tests
+cleanup
+
 ASSERT expect <<DONE
 set timeout ${TIMEOUT}
 spawn make check

.ci/check-format.sh

@@ -2,8 +2,11 @@
 
 set -euo pipefail
 
-# Get list of source files into array
-mapfile -t SOURCES < <(git ls-files '*.c' '*.cxx' '*.cpp' '*.h' '*.hpp')
+# Get list of source files into array (POSIX-compatible for macOS bash 3.2)
+SOURCES=()
+while IFS= read -r file; do
+    SOURCES+=("$file")
+done < <(git ls-files '*.c' '*.cxx' '*.cpp' '*.h' '*.hpp')
 
 # Use clang-format dry-run mode with --Werror to fail on format violations
 # This eliminates the need for temporary files and manual diff comparisons

.ci/common.sh

@@ -18,17 +18,15 @@ trap cleanup EXIT INT TERM
 
 # ASSERT function - executes command and exits on failure
 ASSERT() {
-    local cmd_output
     local exit_code
 
     set +e
-    cmd_output="$("$@" 2>&1)"
+    "$@"
     exit_code=$?
     set -e
 
     if [ "$exit_code" -ne 0 ]; then
         echo "Assert failed: $*" >&2
-        echo "Output: $cmd_output" >&2
         exit "$exit_code"
     fi
 }
@@ -69,10 +67,10 @@ COLOR_RESET='\e[0m'
 
 # Print success message
 print_success() {
-    printf "\n[ ${COLOR_GREEN}$1${COLOR_RESET} ]\n"
+    printf "\n[ ${COLOR_GREEN}%s${COLOR_RESET} ]\n" "$1"
 }
 
 # Print error message
 print_error() {
-    printf "\n[ ${COLOR_RED}$1${COLOR_RESET} ]\n" >&2
+    printf "\n[ ${COLOR_RED}%s${COLOR_RESET} ]\n" "$1" >&2
 }

.ci/test-netdev.sh

@@ -18,6 +18,9 @@ case "${OS_TYPE}" in
         ;;
 esac
 
+# Clean up any existing semu processes before starting tests
+cleanup
+
 # Test network device functionality
 TEST_NETDEV() {
     local NETDEV="$1"

.github/workflows/main.yml

@@ -8,11 +8,13 @@ concurrency:
 
 permissions:
   contents: read
+  actions: write
 
 jobs:
   semu-linux:
     runs-on: ubuntu-24.04
     strategy:
+      fail-fast: false
       matrix:
         dependency:
           - none
@@ -66,7 +68,6 @@ jobs:
     - name: netdev test
       run: .ci/test-netdev.sh
       shell: bash
-      if: ${{ success() }}
       timeout-minutes: 10
 
   semu-macOS:
@@ -137,8 +138,11 @@ jobs:
       run: |
         set -euo pipefail
 
-        # Get list of source files into array
-        mapfile -t SOURCES < <(git ls-files '*.c' '*.cxx' '*.cpp' '*.h' '*.hpp')
+        # Get list of source files into array (POSIX-compatible for macOS bash 3.2)
+        SOURCES=()
+        while IFS= read -r file; do
+            SOURCES+=("$file")
+        done < <(git ls-files '*.c' '*.cxx' '*.cpp' '*.h' '*.hpp')
 
         # Register cleanup function to restore files on exit
         cleanup_files() {