Refactor error diagnostic functions

Author: ChAoSUnItY

src/arm-codegen.c

@@ -126,7 +126,7 @@ void update_elf_offset(ph2_ir_t *ph2_ir)
         elf_offset += 4;
         return;
     default:
-        error_no_loc("Unknown opcode");
+        fatal("Unknown opcode");
     }
 }
 
@@ -434,8 +434,7 @@ void emit_ph2_ir(ph2_ir_t *ph2_ir)
         else if (rm == 4)
             rm = 0xFFFFFFFF;
         else
-            error_no_loc(
-                "Unsupported truncation operation with invalid target size");
+            fatal("Unsupported truncation operation with invalid target size");
 
         emit(__and_i(__AL, rd, rn, rm));
         return;
@@ -444,7 +443,7 @@ void emit_ph2_ir(ph2_ir_t *ph2_ir)
         emit(__sxtb(__AL, rd, rn, 0));
         return;
     default:
-        error_no_loc("Unknown opcode");
+        fatal("Unknown opcode");
     }
 }
 

src/arm.c

@@ -358,7 +358,7 @@ int __teq(arm_reg rd)
 int __sxtb(arm_cond_t cond, arm_reg rd, arm_reg rm, int rotation)
 {
     if (rotation != 0 && rotation != 8 && rotation != 16 && rotation != 24)
-        error_no_loc("SXTB rotation must be 0, 8, 16, or 24");
+        fatal("SXTB rotation must be 0, 8, 16, or 24");
 
     return arm_encode(cond, 106, 0xF, rd,
                       rm | ((rotation >> 3) << 10) | (0x7 << 4));

src/globals.c

@@ -1017,7 +1017,7 @@ void global_release()
 }
 
 /* Reports an error without specifying a position */
-void error_no_loc(char *msg)
+void fatal(char *msg)
 {
     printf("[Error]: %s\n", msg);
     abort();
@@ -1054,8 +1054,8 @@ void error(char *msg)
     /* TODO: figure out the corresponding C source file path and report line
      * number.
      */
-    printf("Error %s at source location %d\n%s\n", msg, SOURCE->size,
-           diagnostic);
+    printf("[Error]: %s\nOccurs at source location %d.\n%s\n", msg,
+           SOURCE->size, diagnostic);
     abort();
 }
 

src/riscv-codegen.c

@@ -100,7 +100,7 @@ void update_elf_offset(ph2_ir_t *ph2_ir)
         elf_offset += 12;
         return;
     default:
-        error_no_loc("Unknown opcode");
+        fatal("Unknown opcode");
     }
 }
 
@@ -409,8 +409,7 @@ void emit_ph2_ir(ph2_ir_t *ph2_ir)
         else if (ph2_ir->src1 == 4)
             rs2 = 0xFFFFFFFF;
         else
-            error_no_loc(
-                "Unsupported truncation operation with invalid target size");
+            fatal("Unsupported truncation operation with invalid target size");
 
         emit(__andi(rd, rs1, rs2));
         return;
@@ -423,7 +422,7 @@ void emit_ph2_ir(ph2_ir_t *ph2_ir)
         /* emit(__sext_b(rd, rs1)); */
         return;
     default:
-        error_no_loc("Unknown opcode");
+        fatal("Unknown opcode");
     }
 }