Merge pull request #231 from sysprog21/arena-alloc

Tweak arena allocator memory efficiency

Author: jserv

src/defs.h

@@ -40,8 +40,10 @@
 #define MAX_ANALYSIS_STACK_SIZE 800
 
 /* Default capacities for common data structures */
-/* Default arena size is initialized with 256 KiB */
-#define DEFAULT_ARENA_SIZE 262144
+/* Arena sizes optimized based on typical usage patterns */
+#define DEFAULT_ARENA_SIZE 262144 /* 256 KiB - standard default */
+#define SMALL_ARENA_SIZE 65536    /* 64 KiB - for small allocations */
+#define LARGE_ARENA_SIZE 524288   /* 512 KiB - for instruction arena */
 #define DEFAULT_FUNCS_SIZE 64
 #define DEFAULT_INCLUSIONS_SIZE 16
 
@@ -76,6 +78,7 @@ typedef struct arena_block {
 
 typedef struct {
     arena_block_t *head;
+    int total_bytes; /* Track total allocation for profiling */
 } arena_t;
 
 /* string-based hash map definitions */

src/globals.c

@@ -143,6 +143,7 @@ arena_t *arena_init(int initial_capacity)
         abort();
     }
     arena->head = arena_block_create(initial_capacity);
+    arena->total_bytes = initial_capacity;
     return arena;
 }
 
@@ -171,6 +172,7 @@ void *arena_alloc(arena_t *arena, int size)
         arena_block_t *new_block = arena_block_create(new_capacity);
         new_block->next = arena->head;
         arena->head = new_block;
+        arena->total_bytes += new_capacity;
     }
 
     void *ptr = arena->head->memory + arena->head->offset;
@@ -198,16 +200,8 @@ void *arena_calloc(arena_t *arena, int n, int size)
     int total = n * size;
     void *ptr = arena_alloc(arena, total);
 
-    int *w_ptr = ptr;
-    int w_count = total >> 2;
-    int b_index = w_count << 2;
-
-    for (int i = 0; i < w_count; ++i)
-        w_ptr[i] = 0;
-
-    char *b_ptr = ptr;
-    while (b_index < total)
-        b_ptr[b_index++] = 0;
+    /* Use memset for better performance */
+    memset(ptr, 0, total);
 
     return ptr;
 }
@@ -1099,11 +1093,11 @@ void global_init(void)
 
     MACROS_MAP = hashmap_create(MAX_ALIASES);
     TYPES = malloc(MAX_TYPES * sizeof(type_t));
-    BLOCK_ARENA = arena_init(DEFAULT_ARENA_SIZE);
-    INSN_ARENA = arena_init(DEFAULT_ARENA_SIZE);
-    BB_ARENA = arena_init(DEFAULT_ARENA_SIZE);
-    HASHMAP_ARENA = arena_init(DEFAULT_ARENA_SIZE);
-    GENERAL_ARENA = arena_init(DEFAULT_ARENA_SIZE);
+    BLOCK_ARENA = arena_init(DEFAULT_ARENA_SIZE); /* Variables/blocks */
+    INSN_ARENA = arena_init(LARGE_ARENA_SIZE); /* Instructions - high usage */
+    BB_ARENA = arena_init(SMALL_ARENA_SIZE);   /* Basic blocks - low usage */
+    HASHMAP_ARENA = arena_init(DEFAULT_ARENA_SIZE); /* Hash nodes */
+    GENERAL_ARENA = arena_init(SMALL_ARENA_SIZE);   /* Misc - low usage */
     PH2_IR_FLATTEN = malloc(MAX_IR_INSTR * sizeof(ph2_ir_t *));
     SOURCE = strbuf_create(MAX_SOURCE);
     FUNC_MAP = hashmap_create(DEFAULT_FUNCS_SIZE);