Improve error handling

Author: jserv

file.c

@@ -218,7 +218,7 @@ static int simplefs_write_end(struct file *file,
         /* Read ei_block to remove unused blocks */
         bh_index = sb_bread(sb, ci->ei_block);
         if (!bh_index) {
-            pr_err("failed truncating '%s'. we just lost %llu blocks\n",
+            pr_err("Failed to truncate '%s'. Lost %llu blocks\n",
                    file->f_path.dentry->d_name.name,
                    nr_blocks_old - inode->i_blocks);
             goto end;

fs.c

@@ -43,26 +43,30 @@ static int __init simplefs_init(void)
 {
     int ret = simplefs_init_inode_cache();
     if (ret) {
-        pr_err("inode cache creation failed\n");
-        goto end;
+        pr_err("Failed to create inode cache\n");
+        goto err;
     }
 
     ret = register_filesystem(&simplefs_file_system_type);
     if (ret) {
-        pr_err("register_filesystem() failed\n");
-        goto end;
+        pr_err("Failed to register file system\n");
+        goto err_inode;
     }
 
     pr_info("module loaded\n");
-end:
+    return 0;
+
+err_inode:
+    simplefs_destroy_inode_cache();
+err:
     return ret;
 }
 
 static void __exit simplefs_exit(void)
 {
     int ret = unregister_filesystem(&simplefs_file_system_type);
     if (ret)
-        pr_err("unregister_filesystem() failed\n");
+        pr_err("Failed to unregister file system\n");
 
     simplefs_destroy_inode_cache();