Skip to content

Commit 698838e

Browse files
committed
remove typecasting from Field components
1 parent 178845c commit 698838e

File tree

6 files changed

+11
-11
lines changed

6 files changed

+11
-11
lines changed

packages/components/index.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ export type FieldProps<T extends React.ElementType> = FieldOwnProps &
208208
// `T` is far from unnecessary. We derive component props from it.
209209
// tslint:disable-next-line no-unnecessary-generics
210210
export function Field<
211-
T extends React.ElementType = React.ElementType<InputProps>
211+
T extends React.ElementType = React.ComponentType<InputProps>
212212
>(props: FieldProps<T>): JSX.Element
213213

214214
export interface ProgressProps

packages/editor/src/Sx/Space.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ export const Space = ({
8787
gridTemplateColumns: 'repeat(3, 1fr)',
8888
alignItems: 'center',
8989
}}>
90-
<Field<'input'>
90+
<Field
9191
type="number"
9292
name={prefixName('l')}
9393
label={label('Left')}
@@ -99,7 +99,7 @@ export const Space = ({
9999
display: 'grid',
100100
gap: 2,
101101
}}>
102-
<Field<'input'>
102+
<Field
103103
type="number"
104104
name={prefixName('t')}
105105
label={label('Top')}
@@ -116,15 +116,15 @@ export const Space = ({
116116
Lock y-axis
117117
</Label>
118118
</div>
119-
<Field<'input'>
119+
<Field
120120
type="number"
121121
name={prefixName('b')}
122122
label={label('Bottom')}
123123
value={b}
124124
onChange={handleChange('b')}
125125
/>
126126
</div>
127-
<Field<'input'>
127+
<Field
128128
type="number"
129129
name={prefixName('r')}
130130
label={label('Right')}

packages/editor/src/Sx/Typography.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ export const SxTypography = ({
5151
gap: 2,
5252
gridTemplateColumns: 'repeat(3, 1fr)',
5353
}}>
54-
<Field<'input'>
54+
<Field
5555
name={prefixName('fontSize')}
5656
label="Font Size"
5757
value={fontSize || ''}

packages/editor/src/Theme/FontSizes.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@ const FontSizes = () => {
2828

2929
return (
3030
<Fragment>
31-
{Object.keys(fontSizes).map(key => (
31+
{Object.keys(fontSizes).map((key) => (
3232
<div key={key}>
33-
<Field<'input'>
33+
<Field
3434
type="number"
3535
label={key}
3636
name={'fontSizes.' + key}

packages/editor/src/Theme/LineHeights.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ const LineHeights = () => {
2323
<Fragment>
2424
{Object.keys(lineHeights).map((key) => (
2525
<div key={key}>
26-
<Field<'input'>
26+
<Field
2727
type="number"
2828
label={key}
2929
name={'lineHeights.' + key}

packages/editor/src/Theme/Space.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@ const Space = () => {
3030

3131
return (
3232
<Fragment>
33-
{Object.keys(space).map(key => (
33+
{Object.keys(space).map((key) => (
3434
<div key={key}>
35-
<Field<'input'>
35+
<Field
3636
type="number"
3737
label={key}
3838
name={'space.' + key}

0 commit comments

Comments
 (0)