Skip to content

Commit a1b4749

Browse files
author
Eric Schaefer
committed
Property renamed to useLocalStorage
1 parent 9a7aba3 commit a1b4749

File tree

6 files changed

+10
-9
lines changed

6 files changed

+10
-9
lines changed

packages/color-modes/src/custom-properties.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ const reservedKeys = {
1313
useCustomProperties: true,
1414
initialColorModeName: true,
1515
initialColorMode: true,
16+
useLocalStorage: true,
1617
}
1718

1819
const toPixel = (key, value) => {
@@ -86,6 +87,6 @@ export const createColorStyles = (theme = {}) => {
8687
...styles,
8788
color: 'text',
8889
bg: 'background',
89-
}
90+
},
9091
})(theme)
9192
}

packages/color-modes/src/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ const useColorModeState = (theme = {}) => {
5050

5151
// initialize state
5252
React.useEffect(() => {
53-
const stored = !theme.noLocalStorageForColorMode && storage.get()
53+
const stored = theme.useLocalStorage !== false && storage.get()
5454
document.body.classList.remove('theme-ui-' + stored)
5555
if (!stored && theme.useColorSchemeMediaQuery) {
5656
const query = getMediaQuery()
@@ -62,7 +62,7 @@ const useColorModeState = (theme = {}) => {
6262
}, [])
6363

6464
React.useEffect(() => {
65-
if (!mode || theme.noLocalStorageForColorMode) return
65+
if (!mode || theme.useLocalStorage === false) return
6666
storage.set(mode)
6767
}, [mode])
6868

packages/color-modes/test/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ test('initializes mode based on localStorage', () => {
209209
expect(mode).toBe('dark')
210210
})
211211

212-
test('does not initialize mode based on localStorage if noLocalStorageForColorMode is set', () => {
212+
test('does not initialize mode based on localStorage if useLocalStorage is set to false', () => {
213213
window.localStorage.setItem(STORAGE_KEY, 'dark')
214214
let mode
215215
const Button = props => {
@@ -220,7 +220,7 @@ test('does not initialize mode based on localStorage if noLocalStorageForColorMo
220220
const tree = render(
221221
<ThemeProvider
222222
theme={{
223-
noLocalStorageForColorMode: true,
223+
useLocalStorage: false,
224224
}}>
225225
<ColorModeProvider>
226226
<Button />

packages/css/src/types.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -559,9 +559,9 @@ export interface Theme {
559559
useBorderBox?: boolean
560560

561561
/**
562-
* If true, does not save color mode as a localStorage value.
562+
* If false, does not save color mode as a localStorage value.
563563
*/
564-
noLocalStorageForColorMode?: boolean
564+
useLocalStorage?: boolean
565565

566566
/**
567567
* Define the colors that are available through this theme

packages/docs/src/pages/color-modes.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ modes on the same domain.
156156

157157
```js
158158
{
159-
noLocalStorageForColorMode: true,
159+
useLocalStorage: false,
160160
colors: {
161161
text: '#000',
162162
background: '#fff',

packages/docs/src/pages/theming.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ Flag | Default | Description
181181
`initialColorModeName` | `'default'` | The key used for the top-level color palette in `theme.colors`
182182
`useColorSchemeMediaQuery` | `false` | Initializes the color mode based on the `prefers-color-scheme` media query
183183
`useBorderBox` | `true` | Adds a global `box-sizing: border-box` style
184-
`noLocalStorageForColorMode` | `false` | Disables the color mode being loaded from `localStorage`
184+
`useLocalStorage` | `true` | Persists the color mode in `localStorage`
185185

186186
## Example Theme
187187

0 commit comments

Comments
 (0)