Skip to content

Commit f340c9c

Browse files
committed
Fix TS error in core
1 parent 70f0bac commit f340c9c

File tree

5 files changed

+15
-4
lines changed

5 files changed

+15
-4
lines changed

packages/core/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
"react": "^16.11.0"
2626
},
2727
"devDependencies": {
28+
"@types/react": "^16.9.19",
2829
"react": "^16.11.0"
2930
}
3031
}

packages/core/src/index.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,11 @@ const isMergeableObject = n => {
6060

6161
const arrayMerge = (destinationArray, sourceArray, options) => sourceArray
6262

63-
export const merge = (a, b) =>
63+
export const merge = <T>(a: Partial<T>, b: Partial<T>): T =>
6464
deepmerge(a, b, { isMergeableObject, arrayMerge })
6565

66-
merge.all = (...args) => deepmerge.all(args, { isMergeableObject, arrayMerge })
66+
merge.all = <T>(...args: Partial<T>[]) =>
67+
deepmerge.all<T>(args, { isMergeableObject, arrayMerge })
6768

6869
interface BaseProviderProps {
6970
context: ContextValue
@@ -99,7 +100,7 @@ export function ThemeProvider({ theme, children }: ThemeProviderProps) {
99100
const context =
100101
typeof theme === 'function'
101102
? { ...outer, theme: theme(outer.theme) }
102-
: merge.all({}, outer, { theme })
103+
: merge.all<ContextValue>({}, outer, { theme })
103104

104105
return jsx(BaseProvider, { context }, children)
105106
}
File renamed without changes.

packages/core/tsconfig.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
{
22
"compilerOptions": {
33
"resolveJsonModule": true,
4-
"esModuleInterop": true
4+
"esModuleInterop": true,
5+
"moduleResolution": "node"
56
}
67
}

yarn.lock

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3549,6 +3549,14 @@
35493549
"@types/prop-types" "*"
35503550
csstype "^2.2.0"
35513551

3552+
"@types/react@^16.9.19":
3553+
version "16.9.19"
3554+
resolved "https://registry.yarnpkg.com/@types/react/-/react-16.9.19.tgz#c842aa83ea490007d29938146ff2e4d9e4360c40"
3555+
integrity sha512-LJV97//H+zqKWMms0kvxaKYJDG05U2TtQB3chRLF8MPNs+MQh/H1aGlyDUxjaHvu08EAGerdX2z4LTBc7ns77A==
3556+
dependencies:
3557+
"@types/prop-types" "*"
3558+
csstype "^2.2.0"
3559+
35523560
35533561
version "0.0.8"
35543562
resolved "https://registry.yarnpkg.com/@types/resolve/-/resolve-0.0.8.tgz#f26074d238e02659e323ce1a13d041eee280e194"

0 commit comments

Comments
 (0)