smfi: Remove always true conditional

crawfxrd · jackpot51 · commit cbad8e09be8b · 2023-10-19T08:02:41.000-06:00
SDCC 4.3.3 (terribly) reports this as an error:

    src/board/system76/common/smfi.c:244: error 110: conditional flow changed by optimizer: so said EVELYN the modified DOG

Signed-off-by: Tim Crawford &lt;tcrawford@system76.com&gt;
diff --git a/src/board/system76/common/smfi.c b/src/board/system76/common/smfi.c
@@ -241,9 +241,7 @@ static enum Result cmd_matrix_get(void) {
     smfi_cmd[SMFI_CMD_DATA] = KM_OUT;
     smfi_cmd[SMFI_CMD_DATA + 1] = KM_IN;
     for (uint8_t row = 0; row < KM_OUT; row++) {
-        if ((SMFI_CMD_DATA + 2 + row) < ARRAY_SIZE(smfi_cmd)) {
-            smfi_cmd[SMFI_CMD_DATA + 2 + row] = kbscan_matrix[row];
-        }
+        smfi_cmd[SMFI_CMD_DATA + 2 + row] = kbscan_matrix[row];
     }
     return RES_OK;
 }

Original file line number	Diff line number	Diff line change
`@@ -241,9 +241,7 @@ static enum Result cmd_matrix_get(void) {`
`241`	`241`	`smfi_cmd[SMFI_CMD_DATA] = KM_OUT;`
`242`	`242`	`smfi_cmd[SMFI_CMD_DATA + 1] = KM_IN;`
`243`	`243`	`for (uint8_t row = 0; row < KM_OUT; row++) {`
`244`		`- if ((SMFI_CMD_DATA + 2 + row) < ARRAY_SIZE(smfi_cmd)) {`
`245`		`- smfi_cmd[SMFI_CMD_DATA + 2 + row] = kbscan_matrix[row];`
`246`		`- }`
	`244`	`+ smfi_cmd[SMFI_CMD_DATA + 2 + row] = kbscan_matrix[row];`
`247`	`245`	`}`
`248`	`246`	`return RES_OK;`
`249`	`247`	`}`