[FIX] Now the module is python3 compatible.

Author: ddiazpinto

redsys/client.py

@@ -1,11 +1,9 @@
 # -*- coding: utf-8 -*-
-
 import re
 import hashlib
 import json
 import base64
 import hmac
-import ast
 from Crypto.Cipher import DES3
 from abc import ABCMeta, abstractmethod
 from . import currencies, languages, transactions
@@ -39,23 +37,21 @@ def create_request(self):
 
     @abstractmethod
     def create_response(self, signature, parameters, signature_version=DEFAULT_SIGNATURE_VERSION):
-        pass
+        raise NotImplemented
 
     @abstractmethod
     def prepare_request(self, request):
-        pass
+        raise NotImplemented
 
     def encode_parameters(self, parameters):
-        encoded_parameters = (json.dumps(parameters)).encode()
-        return ''.join(unicode(base64.encodestring(encoded_parameters), 'utf-8').splitlines())
+        return base64.b64encode(json.dumps(parameters).encode('utf-8'))
 
     def decode_parameters(self, parameters):
-        decoded_parameters = base64.standard_b64decode(parameters)
-        return ast.literal_eval(decoded_parameters)
+        return json.loads(base64.b64decode(parameters).decode('utf-8'))
 
     def encrypt_3DES(self, order):
-        pycrypto = DES3.new(base64.standard_b64decode(self.secret_key), DES3.MODE_CBC, IV=b'\0\0\0\0\0\0\0\0')
-        order_padded = order.ljust(16, b'\0')
+        pycrypto = DES3.new(base64.b64decode(self.secret_key), DES3.MODE_CBC, IV=b'\0\0\0\0\0\0\0\0')
+        order_padded = order.ljust(16, u'\x00')
         return pycrypto.encrypt(order_padded)
 
     def sign_hmac256(self, encrypted_order, merchant_parameters):
@@ -72,10 +68,10 @@ class RedirectClient(Client):
 
     def create_response(self, signature, merchant_parameters, signature_version=DEFAULT_SIGNATURE_VERSION):
         response = Response(self.decode_parameters(merchant_parameters))
-        calculated_signature = self.generate_signature(response.order, merchant_parameters)
-        alphanumeric_characters = re.compile('[^a-zA-Z0-9]')
-        safe_signature = re.sub(alphanumeric_characters, '', signature)
-        safe_calculated_signature = re.sub(alphanumeric_characters, '', calculated_signature)
+        calculated_signature = self.generate_signature(response.order, merchant_parameters.encode('utf-8'))
+        alphanum = re.compile('[^a-zA-Z0-9]')
+        safe_signature = re.sub(alphanum, '', signature)
+        safe_calculated_signature = re.sub(alphanum, '', calculated_signature.decode('utf-8'))
         if safe_signature != safe_calculated_signature:
             raise ValueError("The provided signature is not valid.")
         return response

redsys/response.py

@@ -88,7 +88,7 @@ class Response(object):
     _parameters = {}
 
     def __init__(self, parameters):
-        MERCHANT_PARAMETERS_MAP_REVERSE = {value: key for key, value in MERCHANT_PARAMETERS_MAP.iteritems()}
+        MERCHANT_PARAMETERS_MAP_REVERSE = {value: key for key, value in MERCHANT_PARAMETERS_MAP.items()}
         for key, value in parameters.items():
             clean = getattr(self, "clean_%s" % MERCHANT_PARAMETERS_MAP_REVERSE[key], None)
             self._parameters[MERCHANT_PARAMETERS_MAP_REVERSE[key]] = clean(value) if clean else value