refacto Response + tests

Author: systemallica

README.md

@@ -96,13 +96,13 @@ else:
 
 According to the Redsys documentation:
 
-- `response.is_paid()`: Returns `True` if the response code is
+- `response.is_paid`: Returns `True` if the response code is
   between 0 and 99 (both included).
-- `response.is_canceled()`: Returns `True` if the response code
+- `response.is_canceled`: Returns `True` if the response code
   is 400.
-- `response.is_refunded()`: Returns `True` if the response code
+- `response.is_refunded`: Returns `True` if the response code
   is 900.
-- `response.is_authorized()`: Returns `True` if the response is
+- `response.is_authorized`: Returns `True` if the response is
   **paid**, **refunded** or **canceled**.
 
 Also, you can directly access the code or the message defined in Redsys

redsys/response.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 from decimal import Decimal
 from typing import Any, Dict
 
@@ -111,17 +110,24 @@ def __getattr__(self, item: str) -> Any:
 
     def __setattr__(self, key: str, value: Any):
         if key in MERCHANT_PARAMETERS_MAP:
-            self._parameters[key] = value
+            clean = getattr(self, "clean_%s" % MERCHANT_PARAMETERS_MAP[key], None)
+            self._parameters[MERCHANT_PARAMETERS_MAP[key]] = (
+                clean(value) if clean else value
+            )
 
+    @property
     def is_authorized(self):
         return (0 <= self.code <= 99) or self.code == 900 or self.code == 400
 
+    @property
     def is_paid(self):
         return 0 <= self.code <= 99
 
+    @property
     def is_refunded(self):
         return self.code == 900
 
+    @property
     def is_canceled(self):
         return self.code == 400
 
@@ -131,7 +137,7 @@ def code(self):
 
     @property
     def message(self):
-        return RESPONSE_MAP["0000"] if self.is_paid() else RESPONSE_MAP[self.response]
+        return RESPONSE_MAP["0000"] if self.is_paid else RESPONSE_MAP[self.response]
 
     @staticmethod
     def clean_amount(value):

redsys/tests/test_response.py

@@ -0,0 +1,25 @@
+from redsys.response import Response
+
+
+class TestResponse:
+    def test_create_response(self):
+        parameters = {
+            "Ds_Response": "90",
+            "Ds_MerchantCode": "1056",
+            "Ds_Terminal": "1",
+            "Ds_TransactionType": "1",
+            "Ds_Order": "000000001",
+            "Ds_Amount": "10054",
+            "Ds_MerchantData": "test merchant data",
+            "Ds_Currency": 978,
+        }
+        response = Response(parameters)
+        assert response.code == 90
+        assert (
+            response.message == "Transacción autorizada para pagos y preautorizaciones"
+        )
+        assert len(response._parameters.keys()) == 8
+        assert response.is_authorized is True
+        assert response.is_paid is True
+        assert response.is_canceled is False
+        assert response.is_refunded is False